Обсуждение: pgsql: Add casts from jsonb

Поиск
Список
Период
Сортировка

pgsql: Add casts from jsonb

От
Teodor Sigaev
Дата:
Add casts from jsonb

Add explicit cast from scalar jsonb to all numeric and bool types. It would be
better to have cast from scalar jsonb to text too but there is already a cast
from jsonb to text as just text representation of json. There is no way to have
two different casts for the same type's pair.

Bump catalog version

Author: Anastasia Lubennikova with editorization by Nikita Glukhov and me
Review by: Aleksander Alekseev, Nikita Glukhov, Darafei Praliaskouski
Discussion: https://www.postgresql.org/message-id/flat/0154d35a-24ae-f063-5273-9ffcdf1c7f2e@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c0cbe00fee6d0a5e0ec72c6d68a035e674edc4cc

Modified Files
--------------
src/backend/utils/adt/jsonb.c       | 175 ++++++++++++++++++++++++++++++++++++
src/include/catalog/catversion.h    |   2 +-
src/include/catalog/pg_cast.h       |   9 ++
src/include/catalog/pg_proc.h       |  16 ++++
src/test/regress/expected/jsonb.out | 105 ++++++++++++++++++++++
src/test/regress/sql/jsonb.sql      |  22 +++++
6 files changed, 328 insertions(+), 1 deletion(-)


Re: pgsql: Add casts from jsonb

От
Teodor Sigaev
Дата:
Seems, I broke Windows again, it doesn't like this patch, see
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk&dt=2018-03-29%2013%3A41%3A13

But I don't understand how it could be...

Teodor Sigaev wrote:
> Add casts from jsonb
> 
> Add explicit cast from scalar jsonb to all numeric and bool types. It would be
> better to have cast from scalar jsonb to text too but there is already a cast
> from jsonb to text as just text representation of json. There is no way to have
> two different casts for the same type's pair.
> 
> Bump catalog version
> 
> Author: Anastasia Lubennikova with editorization by Nikita Glukhov and me
> Review by: Aleksander Alekseev, Nikita Glukhov, Darafei Praliaskouski
> Discussion: https://www.postgresql.org/message-id/flat/0154d35a-24ae-f063-5273-9ffcdf1c7f2e@postgrespro.ru
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/c0cbe00fee6d0a5e0ec72c6d68a035e674edc4cc
> 
> Modified Files
> --------------
> src/backend/utils/adt/jsonb.c       | 175 ++++++++++++++++++++++++++++++++++++
> src/include/catalog/catversion.h    |   2 +-
> src/include/catalog/pg_cast.h       |   9 ++
> src/include/catalog/pg_proc.h       |  16 ++++
> src/test/regress/expected/jsonb.out | 105 ++++++++++++++++++++++
> src/test/regress/sql/jsonb.sql      |  22 +++++
> 6 files changed, 328 insertions(+), 1 deletion(-)
> 

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/


Re: pgsql: Add casts from jsonb

От
Teodor Sigaev
Дата:
Hm, it was a random failure?

Teodor Sigaev wrote:
> Seems, I broke Windows again, it doesn't like this patch, see
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk&dt=2018-03-29%2013%3A41%3A13 
> 
> 
> But I don't understand how it could be...
> 
> Teodor Sigaev wrote:
>> Add casts from jsonb
>>
>> Add explicit cast from scalar jsonb to all numeric and bool types. It would be
>> better to have cast from scalar jsonb to text too but there is already a cast
>> from jsonb to text as just text representation of json. There is no way to have
>> two different casts for the same type's pair.
>>
>> Bump catalog version
>>
>> Author: Anastasia Lubennikova with editorization by Nikita Glukhov and me
>> Review by: Aleksander Alekseev, Nikita Glukhov, Darafei Praliaskouski
>> Discussion: 
>> https://www.postgresql.org/message-id/flat/0154d35a-24ae-f063-5273-9ffcdf1c7f2e@postgrespro.ru 
>>
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> https://git.postgresql.org/pg/commitdiff/c0cbe00fee6d0a5e0ec72c6d68a035e674edc4cc
>>
>> Modified Files
>> --------------
>> src/backend/utils/adt/jsonb.c       | 175 ++++++++++++++++++++++++++++++++++++
>> src/include/catalog/catversion.h    |   2 +-
>> src/include/catalog/pg_cast.h       |   9 ++
>> src/include/catalog/pg_proc.h       |  16 ++++
>> src/test/regress/expected/jsonb.out | 105 ++++++++++++++++++++++
>> src/test/regress/sql/jsonb.sql      |  22 +++++
>> 6 files changed, 328 insertions(+), 1 deletion(-)
>>
> 

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/


Re: pgsql: Add casts from jsonb

От
Tom Lane
Дата:
Teodor Sigaev <teodor@sigaev.ru> writes:
> Hm, it was a random failure?

Yeah, whelk seems to be a bit flaky lately.  Not very clear why,
but it's shown several failures that other BF members didn't.

https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=whelk&br=HEAD

Curiously, it's only HEAD that's flapping; the back branches are fine.

            regards, tom lane