Обсуждение: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger
Hi,
PFA patch to make shortcut configurable in debugger module.
--
Regards,
Вложения
Hello Murtuza,
After some review of the code we do have some questions:
- Do we really need to have the shortcuts in the backend?(I already asked this in Khushboo's patch)
- Do we need to have keyAction function(in direct.js) inside this Javascript file or can we extract that an create some tests around it?
- Were there any tests created for these new shortcuts?
Thanks
Joao
On Thu, Feb 8, 2018 at 6:33 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA patch to make shortcut configurable in debugger module.--Regards,
Hi Joao,
On Thu, Feb 8, 2018 at 8:07 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Murtuza,After some review of the code we do have some questions:- Do we really need to have the shortcuts in the backend?(I already asked this in Khushboo's patch)
Yes, to make them configurable by user, User can select the shortcut keys as per their need and we will save them in sqlite database for future reference and use it.
- Do we need to have keyAction function(in direct.js) inside this Javascript file or can we extract that an create some tests around it?
'
keyAction' is a caller function and which executes the handler written in 'keyboard_shortcuts.js'
- Were there any tests created for these new shortcuts?
They are not actual shortcuts but we have used accesskeys for each buttons in debugger toolbar, earlier they were hard coded accesskeys now they are configurable by user through preference dialog.
For Inner panel navigation shortcut keys testcase, I'm not sure how to simulate wcDocker Panels in JS tests without actual DOM element, so I've not added any tests for that.
ThanksJoaoOn Thu, Feb 8, 2018 at 6:33 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to make shortcut configurable in debugger module.--Regards,
Thanks, applied.
Can you please send a followup patch to include the configured keys on the button tooltips, like we do in the Query Tool?
On Thu, Feb 8, 2018 at 11:32 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA patch to make shortcut configurable in debugger module.--Regards,
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Sure.
On Fri, Feb 9, 2018 at 6:14 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.Can you please send a followup patch to include the configured keys on the button tooltips, like we do in the Query Tool?On Thu, Feb 8, 2018 at 11:32 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to make shortcut configurable in debugger module.--Regards,--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
PFA patch to update button tooltip.
--
Regards,
On Fri, Feb 9, 2018 at 6:14 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.Can you please send a followup patch to include the configured keys on the button tooltips, like we do in the Query Tool?On Thu, Feb 8, 2018 at 11:32 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to make shortcut configurable in debugger module.--Regards,--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Thanks, applied.
On Mon, Feb 12, 2018 at 7:27 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,PFA patch to update button tooltip.--Regards,On Fri, Feb 9, 2018 at 6:14 PM, Dave Page <dpage@pgadmin.org> wrote:Thanks, applied.Can you please send a followup patch to include the configured keys on the button tooltips, like we do in the Query Tool?On Thu, Feb 8, 2018 at 11:32 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to make shortcut configurable in debugger module.--Regards,--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company