Обсуждение: Another round of small fixes
Did another round of review of the website code, and found a few small things. Nothing terribly exciting in this round of patches but worth fixing either way I reckon. 0001 - Fix anchors with space in the name attribute 0002 - opensource.org redirects with 301 to https, update links 0003 - Fix incorrect paragraph markup on the donate page 0004 - Make sure to close <input> tags 0005 - Remove unused CSS class from pgFooter elements cheers ./daniel
Вложения
On Thu, Feb 1, 2018 at 9:26 PM, Daniel Gustafsson <daniel@yesql.se> wrote:
Did another round of review of the website code, and found a few small things.
Nothing terribly exciting in this round of patches but worth fixing either way
I reckon.
0001 - Fix anchors with space in the name attribute
0002 - opensource.org redirects with 301 to https, update links
0003 - Fix incorrect paragraph markup on the donate page
0004 - Make sure to close <input> tags
0005 - Remove unused CSS class from pgFooter elements
Congratulations, you are now a committer on the pgweb repository!
And +1 for all those patches, go for it! :)
On 1 Feb 2018, at 20:36, Magnus Hagander <magnus@hagander.net> wrote: > > On Thu, Feb 1, 2018 at 9:26 PM, Daniel Gustafsson <daniel@yesql.se> wrote: > Did another round of review of the website code, and found a few small things. > Nothing terribly exciting in this round of patches but worth fixing either way > I reckon. > > 0001 - Fix anchors with space in the name attribute > 0002 - opensource.org redirects with 301 to https, update links > 0003 - Fix incorrect paragraph markup on the donate page > 0004 - Make sure to close <input> tags > 0005 - Remove unused CSS class from pgFooter elements > > Congratulations, you are now a committer on the pgweb repository! Yay. :) + Justin -- "My grandfather once told me that there are two kinds of people: those who work and those who take the credit. He told me to try to be in the first group; there was less competition there." - Indira Gandhi
> On 01 Feb 2018, at 21:36, Magnus Hagander <magnus@hagander.net> wrote: > > On Thu, Feb 1, 2018 at 9:26 PM, Daniel Gustafsson <daniel@yesql.se <mailto:daniel@yesql.se>> wrote: > Did another round of review of the website code, and found a few small things. > Nothing terribly exciting in this round of patches but worth fixing either way > I reckon. > > 0001 - Fix anchors with space in the name attribute > 0002 - opensource.org <http://opensource.org/> redirects with 301 to https, update links > 0003 - Fix incorrect paragraph markup on the donate page > 0004 - Make sure to close <input> tags > 0005 - Remove unused CSS class from pgFooter elements > > Congratulations, you are now a committer on the pgweb repository! Thanks! > And +1 for all those patches, go for it! :) Will do. cheers ./daniel
> On 01 Feb 2018, at 21:36, Magnus Hagander <magnus@hagander.net> wrote: > > On Thu, Feb 1, 2018 at 9:26 PM, Daniel Gustafsson <daniel@yesql.se <mailto:daniel@yesql.se>> wrote: > Did another round of review of the website code, and found a few small things. > Nothing terribly exciting in this round of patches but worth fixing either way > I reckon. > > 0001 - Fix anchors with space in the name attribute > 0002 - opensource.org <http://opensource.org/> redirects with 301 to https, update links > 0003 - Fix incorrect paragraph markup on the donate page > 0004 - Make sure to close <input> tags > 0005 - Remove unused CSS class from pgFooter elements > > Congratulations, you are now a committer on the pgweb repository! > > And +1 for all those patches, go for it! :) Pushed, thanks for reviewing! cheers ./daniel