Обсуждение: Skytools for 10 — RPM missing
Greetings.
--
skytools package is missing from the PGDG 10 yum repository.
Still, in the source tree I can see `spec` file:
rpm/redhat/master/skytools/EL-7/skytools-10.init
Is it possible to include this RPM into the repo, please?
Victor Yegorov
Hi, On Wed, 2017-12-13 at 22:16 +0200, Victor Yegorov wrote: > skytools package is missing from the PGDG 10 yum repository. > > Still, in the source tree I can see `spec` file: > rpm/redhat/master/skytools/EL-7/skytools-10.init > > Is it possible to include this RPM into the repo, please? Skytools does not compile against Postgres 10. Regards, -- Devrim Gündüz EnterpriseDB: https://www.enterprisedb.com PostgreSQL Consultant, Red Hat Certified Engineer Twitter: @DevrimGunduz , @DevrimGunduzTR
Вложения
Re: Devrim Gündüz 2017-12-13 <1513199824.19931.133.camel@gunduz.org> > > skytools package is missing from the PGDG 10 yum repository. > > > > Still, in the source tree I can see `spec` file: > > rpm/redhat/master/skytools/EL-7/skytools-10.init > > > > Is it possible to include this RPM into the repo, please? > > Skytools does not compile against Postgres 10. On the Debian side, we started moving to the split packages from https://github.com/pgq . Unfortunately, there's a whole bunch of them, and we have only packaged pgq and pgqd yet. The whole thing there looks like a big mess :( Christoph
2017-12-14 11:58 GMT+02:00 Christoph Berg <myon@debian.org>:
On the Debian side, we started moving to the split packages from
https://github.com/pgq . Unfortunately, there's a whole bunch of them,
and we have only packaged pgq and pgqd yet. The whole thing there
looks like a big mess :(
Indeed.
I've looked into the build process, things are crashing on `sql/txid/txid.c` for me:
txid.c: In function 'txid_current_snapshot':
txid.c:207:6: error: 'SerializableSnapshot' undeclared (first use in this function)
if (SerializableSnapshot == NULL)
^
Poking around git on `git log -S SerializableSnapshot` and `git log -- contrib/txid/txid.c` I can see,
that stuff from `skytools` to expose snapshots had been integrated into core years ago (commit 18e3fcc).
Looking at the `sql/txid/Makefile`, they do nothing for that directory if we're on 8.3+.
Versions checks stopped working on 10:
-bash-4.2$ export PGVER=10.1
-bash-4.2$ test $PGVER "<" "8.3" && echo "false" || echo "true"
false
-bash-4.2$ export PGVER=9.6.6
-bash-4.2$ test $PGVER "<" "8.3" && echo "false" || echo "true"
true
I assume that this subdirectory can be excluded from the `Makefile`, 8.3 EOL came years ago.
Doing so makes things compile fine for me.
Patch is as simple as:
diff --git a/rpm/redhat/master/skytools/master/skytools.spec b/rpm/redhat/master/skytools/master/skytools.spec
index dbdb423..bda4715 100644
--- a/rpm/redhat/master/skytools/master/skytools.spec
+++ b/rpm/redhat/master/skytools/master/skytools.spec
@@ -58,6 +58,7 @@ rmdir lib
%if %{pgmajorversion} != 92
sed -ie '/^#include <parser\/keywords.h>/s:parser/keywords.h:common/keywords.h:' sql/pgq/triggers/stringutil.c
%endif
+sed -ie '/^SUBDIRS/s:ticker txid$:ticker:' sql/Makefile
./autogen.sh
%configure --with-pgconfig=%{pginstdir}/bin/pg_config --with-asciidoc
Devrim, do you think it's possible to add this change and add `skytools` to 10 repo?
Victor Yegorov
Hi, On Fri, 2017-12-15 at 15:17 +0200, Victor Yegorov wrote: > Devrim, do you think it's possible to add this change and add `skytools` to > 10 repo? I have no idea whether this patch may break other parts of Skytools or not, so not sure. Regards, -- Devrim Gündüz EnterpriseDB: https://www.enterprisedb.com PostgreSQL Consultant, Red Hat Certified Engineer Twitter: @DevrimGunduz , @DevrimGunduzTR
Вложения
2017-12-15 18:35 GMT+02:00 Devrim Gündüz <devrim@gunduz.org>:
I have no idea whether this patch may break other parts of Skytools or not, so
not sure.
I've made another change than, that fixes PG version detection in the sql/txid/Makefile.
With this patch I got `skytools` build fine here.
Victor Yegorov
Вложения
2017-12-18 21:17 GMT+02:00 Victor Yegorov <vyegorov@gmail.com>:
2017-12-15 18:35 GMT+02:00 Devrim Gündüz <devrim@gunduz.org>:I have no idea whether this patch may break other parts of Skytools or not, so
not sure.I've made another change than, that fixes PG version detection in the sql/txid/Makefile.With this patch I got `skytools` build fine here.
Devrim,
Do you think my 2nd patch is good to be merged?
Victor Yegorov
Hi, On Tue, 2018-01-09 at 13:09 +0200, Victor Yegorov wrote: > Do you think my 2nd patch is good to be merged? Did you try to submit it to upstream for a new release? Regards, -- Devrim Gündüz EnterpriseDB: https://www.enterprisedb.com PostgreSQL Consultant, Red Hat Certified Engineer Twitter: @DevrimGunduz , @DevrimGunduzTR