Обсуждение: [HACKERS] Remove duplicate setting in test/recovery/Makefile

Поиск
Список
Период
Сортировка

[HACKERS] Remove duplicate setting in test/recovery/Makefile

От
Masahiko Sawada
Дата:
Hi,

I found that EXTRA_INSTALL is doubly set at both top and bottom of the
src/test/recovery/Makefile. Is it necessary?

Attached patch fixes this.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Вложения

Re: [HACKERS] Remove duplicate setting in test/recovery/Makefile

От
Michael Paquier
Дата:
On Wed, Nov 8, 2017 at 10:38 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> Hi,
>
> I found that EXTRA_INSTALL is doubly set at both top and bottom of the
> src/test/recovery/Makefile. Is it necessary?
>
> Attached patch fixes this.

Indeed, there is some bad overlap between d851bef and 1148e22a. Better
to CC Simon who committed both things.
--
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Remove duplicate setting in test/recovery/Makefile

От
Masahiko Sawada
Дата:
On Wed, Nov 8, 2017 at 10:46 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Wed, Nov 8, 2017 at 10:38 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> Hi,
>>
>> I found that EXTRA_INSTALL is doubly set at both top and bottom of the
>> src/test/recovery/Makefile. Is it necessary?
>>
>> Attached patch fixes this.
>
> Indeed, there is some bad overlap between d851bef and 1148e22a. Better
> to CC Simon who committed both things.

Thank you. I've added this to the next CF so as not to forget.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


Re: [HACKERS] Remove duplicate setting in test/recovery/Makefile

От
Robert Haas
Дата:
On Thu, Nov 16, 2017 at 7:15 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> Thank you. I've added this to the next CF so as not to forget.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [HACKERS] Remove duplicate setting in test/recovery/Makefile

От
Masahiko Sawada
Дата:
On Fri, Nov 17, 2017 at 5:36 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Thu, Nov 16, 2017 at 7:15 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> Thank you. I've added this to the next CF so as not to forget.
>
> Committed.
>

Thank you.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center