Обсуждение: Re: postmaster.pid

Поиск
Список
Период
Сортировка

Re: postmaster.pid

От
"Dave Page"
Дата:

> -----Original Message-----
> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> Sent: 24 August 2004 18:17
> To: Andrew Dunstan
> Cc: Dave Page; Barry Lind;
> pgsql-hackers-win32@postgresql.org; Max Dunn
> Subject: Re: [pgsql-hackers-win32] postmaster.pid
>
> Andrew Dunstan <andrew@dunslane.net> writes:
> > Tom Lane wrote:
> >> Should you not send the zero signal the same way as other signals,
> >> and just let the recipient ignore it?
>
> > So Dave's patch is clearly wrong where it returns EINVAL. How we
> > should distinguish between the other two cases I am less sure of -
> > IANAWP ;-)

Hey, I did say it was a quick hack!

> I think we could just return ESRCH always if we have no pipe
> for the process.  The callers will actually treat these
> errnos the same anyway.

OK - do you want me to post a corrected patch to -patches, or will you
correct and commit my previous post?

Regards, Dave

Re: postmaster.pid

От
Tom Lane
Дата:
"Dave Page" <dpage@vale-housing.co.uk> writes:
> OK - do you want me to post a corrected patch to -patches, or will you
> correct and commit my previous post?

I'm not going to fix it because I have no way to test it.

            regards, tom lane