Обсуждение: Re: PITR on Win32 - Archive and Restore

Поиск
Список
Период
Сортировка

Re: PITR on Win32 - Archive and Restore

От
"Merlin Moncure"
Дата:
>
> I don't think that's workable unless we intend to distribute it.
Gary's
> suggestion of using xcopy is probably a good one.
>
> I will install MSys and friends on my new Windows machine and play
> around to see what works, unless someone comes up with a tested
solution
> first.

You know, it might be nice to have the inserted path be set up with
slashes dependant on the OS type.  Or, perhaps an alternate set of
macros in the archive string to reverse the slashes.   Forcing people to
use xcopy or cp will cause problems in various scenarios.

Merlin



Re: PITR on Win32 - Archive and Restore

От
"Christian Klemke"
Дата:
Guys,

did you notice my earlier CopyFile / CopyFileEx posting (at about 10:20
German time) ?
If you want to stick with an external copy executable (which I don't quite
understand), just go and write one yourself and provide it for Windows
users. Leaving aside the neccessary checks, it might be as simple as:

#include <windows.h>
int main(char* args[]) {
  return CopyFile(args[0],args[1],TRUE);
}

Adding a proprietary parser for secure handling of quotes (to deal of paths
containing space)s should be simple, I'm sure you have adequate functions in
your Postgres library. Link it to a file called copy.exe or cp.exe or
wahtever and add it to the PGBIN directory.

Cheers,
Christian.


----- Original Message -----
From: "Merlin Moncure" <merlin.moncure@rcsonline.com>
To: "Andrew Dunstan" <andrew@dunslane.net>
Cc: <pgsql-hackers-win32@postgresql.org>; "Simon Riggs"
<simon@2ndquadrant.com>
Sent: Monday, August 09, 2004 2:54 PM
Subject: Re: [pgsql-hackers-win32] PITR on Win32 - Archive and Restore


>
> I don't think that's workable unless we intend to distribute it.
Gary's
> suggestion of using xcopy is probably a good one.
>
> I will install MSys and friends on my new Windows machine and play
> around to see what works, unless someone comes up with a tested
solution
> first.

You know, it might be nice to have the inserted path be set up with
slashes dependant on the OS type.  Or, perhaps an alternate set of
macros in the archive string to reverse the slashes.   Forcing people to
use xcopy or cp will cause problems in various scenarios.

Merlin



---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
      joining column's datatypes do not match



Re: PITR on Win32 - Archive and Restore

От
Andrew Dunstan
Дата:
Christian,

what you have not done is to follow the context of the discussion. This
command is a configuration option, and thus executed with a system()
call. We do not have the luxury of hardcoding it available to us.

Note that system() actually calls cmd.exe, so your previous comment
about needing to use cmd /c is also wrong.

cheers

andrew


Christian Klemke wrote:

>Guys,
>
>did you notice my earlier CopyFile / CopyFileEx posting (at about 10:20
>German time) ?
>If you want to stick with an external copy executable (which I don't quite
>understand), just go and write one yourself and provide it for Windows
>users. Leaving aside the neccessary checks, it might be as simple as:
>
>#include <windows.h>
>int main(char* args[]) {
>  return CopyFile(args[0],args[1],TRUE);
>}
>
>Adding a proprietary parser for secure handling of quotes (to deal of paths
>containing space)s should be simple, I'm sure you have adequate functions in
>your Postgres library. Link it to a file called copy.exe or cp.exe or
>wahtever and add it to the PGBIN directory.
>
>
>
>
>