Обсуждение: [HACKERS] psql \d sequence display
In PostgreSQL 10, the sequence metadata moved from the sequence "relation" to a system catalog. The psql \d sequence command was not updated for that. (It just did SELECT * FROM seq and there were no tests, so this was missed.) Attached is a patch that fixes that up, taking the opportunity to design a more useful sequence display that is not merely hacked on to the general relation display. This should be fixed for PG10, so if you have any feedback on the design, please let me know soon. Examples are in the attached patch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Вложения
Hello, > This should be fixed for PG10, so if you have any feedback on the > design, please let me know soon. Works for me on head against a 9.6 server, which is good. My 0.02 €: \d+ does not show more. Maybe Type, Min, Max, Inc & Cycles are enough for \d? The next/future or last/previous value is not shown. If one could be available it would be nice to have? Maybe some names are a little large, eg "Increment" could be "Inc.". The value is nearly always 1? Not sure why it is "Cycles" (plural) instead of "Cycle". The non regression test could also show a more esoteric sequence (cyclic, ...). There is no documentation. Maybe none is needed. I do not understand why some queries have "... \n" "... \n" and others have "\n ..." "\n ...". I would suggest to homogeneize around the former, because "\nFROM ..." is less readable. -- Fabien. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On 9/25/17 13:53, Fabien COELHO wrote: > \d+ does not show more. > > Maybe Type, Min, Max, Inc & Cycles are enough for \d? That seems kind of arbitrary. Start and Cache are just as relevant. > The next/future or last/previous value is not shown. If one could be > available it would be nice to have? You can get those from the sequence. Running \d on a table doesn't show the table data either. So I think this is a valid distinction. > Maybe some names are a little large, eg "Increment" could be "Inc.". > The value is nearly always 1? Yeah, but then that would look weird if only one heading were abbreviated. The total display width is good, so we don't need to squeeze it too hard. > Not sure why it is "Cycles" (plural) instead of "Cycle". This is meant to be a verb, as in "does it cycle?". I have changed it to "Cycles?" to match other similar headings. > I do not understand why some queries have "... \n" "... \n" and others > have "\n ..." "\n ...". I would suggest to homogeneize around the former, > because "\nFROM ..." is less readable. Yeah that is a bit ugly, but I have just moved existing code around. I have now committed my patch with minor adjustments, so we have something working for PG10. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers