Обсуждение: [HACKERS] obsolete code in pg_upgrade

Поиск
Список
Период
Сортировка

[HACKERS] obsolete code in pg_upgrade

От
Peter Eisentraut
Дата:
It seems to me that this code in pg_upgrade/check.c has been useless
since at least version 9.1:
   /* Is it 9.0 but without tablespace directories? */   if (GET_MAJOR_VERSION(new_cluster.major_version) == 900 &&
 new_cluster.controldata.cat_ver < TABLE_SPACE_SUBDIRS_CAT_VER)       pg_fatal("This utility can only upgrade to
PostgreSQLversion
 
9.0 after 2010-01-11\n"                "because of backend API changes made during
development.\n");


-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Re: [HACKERS] obsolete code in pg_upgrade

От
Bruce Momjian
Дата:
On Tue, Aug 22, 2017 at 08:28:15PM -0400, Peter Eisentraut wrote:
> It seems to me that this code in pg_upgrade/check.c has been useless
> since at least version 9.1:
> 
>     /* Is it 9.0 but without tablespace directories? */
>     if (GET_MAJOR_VERSION(new_cluster.major_version) == 900 &&
>         new_cluster.controldata.cat_ver < TABLE_SPACE_SUBDIRS_CAT_VER)
>         pg_fatal("This utility can only upgrade to PostgreSQL version
> 9.0 after 2010-01-11\n"
>                  "because of backend API changes made during
> development.\n");

Coming in late, but agreed.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +