Обсуждение: [pgsql-pkg-debian] Debian packaging of the q3c and pgsphere extensions

Hi,

I am posting to both lists since I am unsure where the best place is. I
am however not subscribed to any of them, so please keep in Cc for the
moment:

As a dependency of the Virtual Observatory "DACHS" package [1], which I
am planning to package, I need to have the "q3c" [2] and "pgsphere" [3]
packages in Debian. All packages already exist in a separate repository
[4]; the initial packaging was done by Florian Rothmaier.

However, I am very new to Postgresql extension packaging, and therefore
I would ask to get some useful hints here. Especially: Is there a Debian
policy for postgresql extensions that documents the preferred way for
packaging? A preferred git repository? Or is the Debian Science git
repository OK? Are extensions dependent on the postgresql version, and
if yes, how should I create the package to enable smooth transitions?
What are the preferred names for the packages?

I would be glad to get some initial startup here (maybe a simple
template or so)?

Best regards

Ole

[1] http://docs.g-vo.org/DaCHS/
[2] https://github.com/segasai/q3c
[3] http://pgsphere.github.io/download.html
[4] http://soft.g-vo.org/repo

Re: Ole Streicher 2017-07-31 <d478ece1-f884-0576-91f3-910820d54669@debian.org>
> I am posting to both lists since I am unsure where the best place is. I
> am however not subscribed to any of them, so please keep in Cc for the
> moment:

Hi Ole,

both lists are fine.

> As a dependency of the Virtual Observatory "DACHS" package [1], which I
> am planning to package, I need to have the "q3c" [2] and "pgsphere" [3]
> packages in Debian. All packages already exist in a separate repository
> [4]; the initial packaging was done by Florian Rothmaier.

Florian was talking to me about these some years back, iirc we were
close to getting the packages polished up, but then communication got
stuck at some point. Thanks for taking this up again!

I'd also like to include the packages on apt.postgresql.org.

> However, I am very new to Postgresql extension packaging, and therefore
> I would ask to get some useful hints here. Especially: Is there a Debian
> policy for postgresql extensions that documents the preferred way for
> packaging?

pg_buildext(1) and dh_make_pgxs(1) (both from postgresql-server-dev-all)
should provide a working skeleton at least for the case of extension-only
packages.

> A preferred git repository? Or is the Debian Science git
> repository OK?

Any git repo works.

> Are extensions dependent on the postgresql version, and
> if yes, how should I create the package to enable smooth transitions?

The server major version is encoded in the .so files built and the
path names, so they are dependent, yes.

> What are the preferred names for the packages?

postgresql-9.6-q3c etc.

> I would be glad to get some initial startup here (maybe a simple
> template or so)?

See pg_buildext(1) and dh_make_pgxs(1).

The existing

https://anonscm.debian.org/cgit/debian-science/packages/q3c.git/
https://anonscm.debian.org/cgit/debian-science/packages/pgsphere.git/

repositories seem mostly fine even by today's packaging standards
(maybe some of the extra clutter in debian/rules could be removed), so
you should probably go from there.

Fwiw, I'd strongly recommend to add a debian/tests/ testsuite (see
also pg_buildext(1)), even if it's just a "create extension q3c;", so
we have some test coverage.

Thanks,
Christoph

Hi Christoph,

thank you very much for your reply with a first help.


On 03.08.2017 11:25, Christoph Berg wrote:
> Florian was talking to me about these some years back, iirc we were
> close to getting the packages polished up, but then communication got
> stuck at some point. Thanks for taking this up again!

I have polished both packages, with the repository still in the
debian-science section (but I will move them to pkg-postgresql as soon
as I become a member). They look fine to me now (except tests; see
below), but could you have a look there?

> I'd also like to include the packages on apt.postgresql.org.

Sure, however this is out of my own scope.

> pg_buildext(1) and dh_make_pgxs(1) (both from postgresql-server-dev-all)
> should provide a working skeleton at least for the case of extension-only
> packages.

Yea, pg_buildext is nice.

> Fwiw, I'd strongly recommend to add a debian/tests/ testsuite (see
> also pg_buildext(1)), even if it's just a "create extension q3c;", so
> we have some test coverage.

I'd love to. Especially q3c has this already enabled. However I don't
know how to enable a test postgresql database server. When I just add
postgresql-client to d/control[.in], I get

createdb q3c_test
createdb: could not connect to database template1: could not connect to
server: No such file or directory
    Is the server running locally and accepting
    connections on Unix domain socket "/var/run/postgresql/.s.PGSQL.5432"?
Makefile:37: recipe for target 'test' failed

during the build. Do you have any hints here?

Best regards

Ole