Обсуждение: [HACKERS] Missing comment for max_logical_replication_workers inpostgresql.conf.sample
Hi, I found that postgresql.conf.sample is missing a comment to note that changing max_logical_replication_workers requires restart of the server. Other such parameters has the comments, so I think the new parameter also needs this. Attached is a simple patch to fix this. Regards, -- Yugo Nagata <nagata@sraoss.co.jp> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Вложения
Re: [HACKERS] Missing comment for max_logical_replication_workers in postgresql.conf.sample
От
Masahiko Sawada
Дата:
On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nagata@sraoss.co.jp> wrote: > Hi, > > I found that postgresql.conf.sample is missing a comment > to note that changing max_logical_replication_workers requires > restart of the server. > > Other such parameters has the comments, so I think the new > parameter also needs this. Attached is a simple patch to fix > this. > Good point. Similarly, dynamic_shared_memory_type and event_source are required restarting to change but are not mentioned in postgresql.conf.sample. Should we add a comment as well? Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
On Thu, 27 Jul 2017 14:38:29 +0900 Masahiko Sawada <sawada.mshk@gmail.com> wrote: > On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nagata@sraoss.co.jp> wrote: > > Hi, > > > > I found that postgresql.conf.sample is missing a comment > > to note that changing max_logical_replication_workers requires > > restart of the server. > > > > Other such parameters has the comments, so I think the new > > parameter also needs this. Attached is a simple patch to fix > > this. > > > > Good point. Similarly, dynamic_shared_memory_type and event_source are > required restarting to change but are not mentioned in > postgresql.conf.sample. Should we add a comment as well? I think so. The updated patch is attached. > > Regards, > > -- > Masahiko Sawada > NIPPON TELEGRAPH AND TELEPHONE CORPORATION > NTT Open Source Software Center -- Yugo Nagata <nagata@sraoss.co.jp> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Вложения
Attached patch looks good except the excessive tab stops: + # (change requires restart) I will commit/push this with removing the excessive tab stops if there's no objection. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp > On Thu, 27 Jul 2017 14:38:29 +0900 > Masahiko Sawada <sawada.mshk@gmail.com> wrote: > >> On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nagata@sraoss.co.jp> wrote: >> > Hi, >> > >> > I found that postgresql.conf.sample is missing a comment >> > to note that changing max_logical_replication_workers requires >> > restart of the server. >> > >> > Other such parameters has the comments, so I think the new >> > parameter also needs this. Attached is a simple patch to fix >> > this. >> > >> >> Good point. Similarly, dynamic_shared_memory_type and event_source are >> required restarting to change but are not mentioned in >> postgresql.conf.sample. Should we add a comment as well? > > I think so. The updated patch is attached. > >> >> Regards, >> >> -- >> Masahiko Sawada >> NIPPON TELEGRAPH AND TELEPHONE CORPORATION >> NTT Open Source Software Center > > > -- > Yugo Nagata <nagata@sraoss.co.jp>
> Attached patch looks good except the excessive tab stops: > + # (change requires restart) > > I will commit/push this with removing the excessive tab stops if > there's no objection. Done. Each fix were pushed in separate commit because the version needed to back patch are differ. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp