Обсуждение: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

Hi,

Please find attached patch to set default layout of file listing as a list in file manager.

Also replaced alertify with out custom alertifywrapper in file manager utils.js

Hi

On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

Please find attached patch to set default layout of file listing as a list in file manager.

Also replaced alertify with out custom alertifywrapper in file manager utils.js

This isn't a bad idea on the face of it, but there are some things to fix/consider:

- The HTML file seems to be missing translation markers. Can you add them throughout please?

- We should save the users preference in the config database.

- The grid view seems to underline the file size and for no apparent reason change the mouse cursor to ? on mouseover. Let's change the text style to be consistent and get rid of the mouseover.

Thanks!

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi,

On Mon, Jul 24, 2017 at 4:23 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

Please find attached patch to set default layout of file listing as a list in file manager.

Also replaced alertify with out custom alertifywrapper in file manager utils.js

This isn't a bad idea on the face of it, but there are some things to fix/consider:

- The HTML file seems to be missing translation markers. Can you add them throughout please?

- We should save the users preference in the config database.

- The grid view seems to underline the file size and for no apparent reason change the mouse cursor to ? on mouseover. Let's change the text style to be consistent and get rid of the mouseover.

Please find updated patch

On Wed, Jul 26, 2017 at 11:06 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

On Mon, Jul 24, 2017 at 4:23 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

Please find attached patch to set default layout of file listing as a list in file manager.

Also replaced alertify with out custom alertifywrapper in file manager utils.js

This isn't a bad idea on the face of it, but there are some things to fix/consider:

- The HTML file seems to be missing translation markers. Can you add them throughout please?

- We should save the users preference in the config database.

- The grid view seems to underline the file size and for no apparent reason change the mouse cursor to ? on mouseover. Let's change the text style to be consistent and get rid of the mouseover.

Please find updated patch

Thanks, committed with some naming tweaks... however, I do think the setting should be updated when the user toggles it within the file dialogue. Can you add code to set that config option when the user toggles the mode on the fly please?

Thanks.

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company