Обсуждение: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

hiHi,

PFA patch to add functionality which will allow super user to cancel long running queries from dashboard.

RM#1812

Steps used to test:

1) Open psql session, Connect to 'test' database on respective server

2) Execute "select pg_sleep(1000);"

3) Open pgAdmin4

4) Connect to respective server

5) Click on Dashboard

6) Check "Sessions" tab under "Server activity" section then look for active sessions for test database.

7) Click on cancel button and cancel the active session

8) Check psql session now, you will see "ERROR:  canceling statement due to user request"

Hi

On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

hiHi,

PFA patch to add functionality which will allow super user to cancel long running queries from dashboard.

RM#1812

Steps used to test:

1) Open psql session, Connect to 'test' database on respective server

2) Execute "select pg_sleep(1000);"

3) Open pgAdmin4

4) Connect to respective server

5) Click on Dashboard

6) Check "Sessions" tab under "Server activity" section then look for active sessions for test database.

7) Click on cancel button and cancel the active session

8) Check psql session now, you will see "ERROR:  canceling statement due to user request"

Some comments:

- The action here is to cancel the active query in the backend, not the session - so messages etc. should say things like "Cancel Active Query?"

- The grid should refresh following the cancel operation.

- Can you fix the vertical alignment while you're working on this? The new button really makes the poor alignment stand out.

- This should not be superuser only - regular users should be able to cancel their own queries.

- On PG10, background workers are also shown in the dashboard. Should we prevent attempts to cancel their work (they'll fail anyway I believe). 

Thanks!

 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi!

I can't seem to get the patch to completely work on my computer, only the close icon shows up plus the dialog and success/error messages, but here are some comments:

+1 to Dave's comment about refreshing after the cancel operation

- We're working on a patch for updating alerts in the Dashboard tab which updates the grays in the Database activities panel and changes the border around the refresh button and search bar to 1px. This hasn't been submitted yet but just a heads up as you work on the alignment.

- Something to consider is how a super user will identify which session should be closed. Is that information there?

- Are there sessions that should never be closed? If so, do they also need close buttons? (Probably not, because that will lead the user to an error message, which is not fun)

- Perhaps this is a good feature to review with Chethana! :)

On Mon, Jul 17, 2017 at 5:37 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

On Mon, Jul 17, 2017 at 3:01 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

hiHi,

PFA patch to add functionality which will allow super user to cancel long running queries from dashboard.

RM#1812

Steps used to test:

1) Open psql session, Connect to 'test' database on respective server

2) Execute "select pg_sleep(1000);"

3) Open pgAdmin4

4) Connect to respective server

5) Click on Dashboard

6) Check "Sessions" tab under "Server activity" section then look for active sessions for test database.

7) Click on cancel button and cancel the active session

8) Check psql session now, you will see "ERROR:  canceling statement due to user request"

Some comments:

- The action here is to cancel the active query in the backend, not the session - so messages etc. should say things like "Cancel Active Query?"

 

- The grid should refresh following the cancel operation.

- Can you fix the vertical alignment while you're working on this? The new button really makes the poor alignment stand out.

- This should not be superuser only - regular users should be able to cancel their own queries.

- On PG10, background workers are also shown in the dashboard. Should we prevent attempts to cancel their work (they'll fail anyway I believe). 

Thanks!

 

Sure, I'll work on these comments & send updated patch. 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi Shirley,

On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang <swang@pivotal.io> wrote:

Hi!

I can't seem to get the patch to completely work on my computer, only the close icon shows up plus the dialog and success/error messages, but here are some comments:

Because  we are just cancelling the active running query, so if the start of the session is 'Active' when you cancel it will simply goto 'Idle' stat. 

+1 to Dave's comment about refreshing after the cancel operation

I'll fix this. 

- We're working on a patch for updating alerts in the Dashboard tab which updates the grays in the Database activities panel and changes the border around the refresh button and search bar to 1px. This hasn't been submitted yet but just a heads up as you work on the alignment.

- Something to consider is how a super user will identify which session should be closed. Is that information there?

I think super user can cancel everything except main connection session & as Dave mentioned in previous email that background workers in PG10. 

- Are there sessions that should never be closed? If so, do they also need close buttons? (Probably not, because that will lead the user to an error message, which is not fun)

In Backgrid, we can not exclude specific column from certain rows if it renders in one row then it will render for every row in the grid, What we can do is, it will throw an error when user is not eligible to cancel the active running query. 

- Perhaps this is a good feature to review with Chethana! :)

On Mon, Jul 17, 2017 at 5:37 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

On Mon, Jul 17, 2017 at 3:01 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

hiHi,

PFA patch to add functionality which will allow super user to cancel long running queries from dashboard.

RM#1812

Steps used to test:

1) Open psql session, Connect to 'test' database on respective server

2) Execute "select pg_sleep(1000);"

3) Open pgAdmin4

4) Connect to respective server

5) Click on Dashboard

6) Check "Sessions" tab under "Server activity" section then look for active sessions for test database.

7) Click on cancel button and cancel the active session

8) Check psql session now, you will see "ERROR:  canceling statement due to user request"

Some comments:

- The action here is to cancel the active query in the backend, not the session - so messages etc. should say things like "Cancel Active Query?"

 

- The grid should refresh following the cancel operation.

- Can you fix the vertical alignment while you're working on this? The new button really makes the poor alignment stand out.

- This should not be superuser only - regular users should be able to cancel their own queries.

- On PG10, background workers are also shown in the dashboard. Should we prevent attempts to cancel their work (they'll fail anyway I believe). 

Thanks!

 

Sure, I'll work on these comments & send updated patch. 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thanks, applied.

How much effort do you think it would take to turn the table into a subnode control so we can show the SQL query and other missing fields from pg_stat_activity on that tab?

On Mon, Jul 24, 2017 at 11:45 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

Please find updated patch.

On Tue, Jul 18, 2017 at 8:05 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Shirley,

On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang <swang@pivotal.io> wrote:

Hi!

I can't seem to get the patch to completely work on my computer, only the close icon shows up plus the dialog and success/error messages, but here are some comments:

Because  we are just cancelling the active running query, so if the start of the session is 'Active' when you cancel it will simply goto 'Idle' stat. 

+1 to Dave's comment about refreshing after the cancel operation

I'll fix this. 

- We're working on a patch for updating alerts in the Dashboard tab which updates the grays in the Database activities panel and changes the border around the refresh button and search bar to 1px. This hasn't been submitted yet but just a heads up as you work on the alignment.

- Something to consider is how a super user will identify which session should be closed. Is that information there?

I think super user can cancel everything except main connection session & as Dave mentioned in previous email that background workers in PG10. 

- Are there sessions that should never be closed? If so, do they also need close buttons? (Probably not, because that will lead the user to an error message, which is not fun)

In Backgrid, we can not exclude specific column from certain rows if it renders in one row then it will render for every row in the grid, What we can do is, it will throw an error when user is not eligible to cancel the active running query. 

- Perhaps this is a good feature to review with Chethana! :)

On Mon, Jul 17, 2017 at 5:37 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

On Mon, Jul 17, 2017 at 3:01 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

hiHi,

PFA patch to add functionality which will allow super user to cancel long running queries from dashboard.

RM#1812

Steps used to test:

1) Open psql session, Connect to 'test' database on respective server

2) Execute "select pg_sleep(1000);"

3) Open pgAdmin4

4) Connect to respective server

5) Click on Dashboard

6) Check "Sessions" tab under "Server activity" section then look for active sessions for test database.

7) Click on cancel button and cancel the active session

8) Check psql session now, you will see "ERROR:  canceling statement due to user request"

Some comments:

- The action here is to cancel the active query in the backend, not the session - so messages etc. should say things like "Cancel Active Query?"

 

- The grid should refresh following the cancel operation.

- Can you fix the vertical alignment while you're working on this? The new button really makes the poor alignment stand out.

- This should not be superuser only - regular users should be able to cancel their own queries.

- On PG10, background workers are also shown in the dashboard. Should we prevent attempts to cancel their work (they'll fail anyway I believe). 

Thanks!

 

Sure, I'll work on these comments & send updated patch. 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi Dave,

On Mon, Jul 24, 2017 at 4:44 PM, Dave Page <dpage@pgadmin.org> wrote:

Thanks, applied.

How much effort do you think it would take to turn the table into a subnode control so we can show the SQL query and other missing fields from pg_stat_activity on that tab?

I think around 2-3 days would be needed. 

 

On Mon, Jul 24, 2017 at 11:45 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

Please find updated patch.

On Tue, Jul 18, 2017 at 8:05 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Shirley,

On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang <swang@pivotal.io> wrote:

Hi!

I can't seem to get the patch to completely work on my computer, only the close icon shows up plus the dialog and success/error messages, but here are some comments:

Because  we are just cancelling the active running query, so if the start of the session is 'Active' when you cancel it will simply goto 'Idle' stat. 

+1 to Dave's comment about refreshing after the cancel operation

I'll fix this. 

- We're working on a patch for updating alerts in the Dashboard tab which updates the grays in the Database activities panel and changes the border around the refresh button and search bar to 1px. This hasn't been submitted yet but just a heads up as you work on the alignment.

- Something to consider is how a super user will identify which session should be closed. Is that information there?

I think super user can cancel everything except main connection session & as Dave mentioned in previous email that background workers in PG10. 

- Are there sessions that should never be closed? If so, do they also need close buttons? (Probably not, because that will lead the user to an error message, which is not fun)

In Backgrid, we can not exclude specific column from certain rows if it renders in one row then it will render for every row in the grid, What we can do is, it will throw an error when user is not eligible to cancel the active running query. 

- Perhaps this is a good feature to review with Chethana! :)

On Mon, Jul 17, 2017 at 5:37 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

On Mon, Jul 17, 2017 at 3:01 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

hiHi,

PFA patch to add functionality which will allow super user to cancel long running queries from dashboard.

RM#1812

Steps used to test:

1) Open psql session, Connect to 'test' database on respective server

2) Execute "select pg_sleep(1000);"

3) Open pgAdmin4

4) Connect to respective server

5) Click on Dashboard

6) Check "Sessions" tab under "Server activity" section then look for active sessions for test database.

7) Click on cancel button and cancel the active session

8) Check psql session now, you will see "ERROR:  canceling statement due to user request"

Some comments:

- The action here is to cancel the active query in the backend, not the session - so messages etc. should say things like "Cancel Active Query?"

 

- The grid should refresh following the cancel operation.

- Can you fix the vertical alignment while you're working on this? The new button really makes the poor alignment stand out.

- This should not be superuser only - regular users should be able to cancel their own queries.

- On PG10, background workers are also shown in the dashboard. Should we prevent attempts to cancel their work (they'll fail anyway I believe). 

Thanks!

 

Sure, I'll work on these comments & send updated patch. 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jul 24, 2017 at 1:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

On Mon, Jul 24, 2017 at 4:44 PM, Dave Page <dpage@pgadmin.org> wrote:

Thanks, applied.

How much effort do you think it would take to turn the table into a subnode control so we can show the SQL query and other missing fields from pg_stat_activity on that tab?

I think around 2-3 days would be needed. 

OK - can you add a Redmine and work on that please? It's been a known deficiency for quite a while, and whilst working on this patch I realised just how badly we really need to see the SQL there.

Thanks.

 

 

On Mon, Jul 24, 2017 at 11:45 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

Please find updated patch.

On Tue, Jul 18, 2017 at 8:05 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Shirley,

On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang <swang@pivotal.io> wrote:

Hi!

I can't seem to get the patch to completely work on my computer, only the close icon shows up plus the dialog and success/error messages, but here are some comments:

Because  we are just cancelling the active running query, so if the start of the session is 'Active' when you cancel it will simply goto 'Idle' stat. 

+1 to Dave's comment about refreshing after the cancel operation

I'll fix this. 

- We're working on a patch for updating alerts in the Dashboard tab which updates the grays in the Database activities panel and changes the border around the refresh button and search bar to 1px. This hasn't been submitted yet but just a heads up as you work on the alignment.

- Something to consider is how a super user will identify which session should be closed. Is that information there?

I think super user can cancel everything except main connection session & as Dave mentioned in previous email that background workers in PG10. 

- Are there sessions that should never be closed? If so, do they also need close buttons? (Probably not, because that will lead the user to an error message, which is not fun)

In Backgrid, we can not exclude specific column from certain rows if it renders in one row then it will render for every row in the grid, What we can do is, it will throw an error when user is not eligible to cancel the active running query. 

- Perhaps this is a good feature to review with Chethana! :)

On Mon, Jul 17, 2017 at 5:37 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

On Mon, Jul 17, 2017 at 3:01 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

hiHi,

PFA patch to add functionality which will allow super user to cancel long running queries from dashboard.

RM#1812

Steps used to test:

1) Open psql session, Connect to 'test' database on respective server

2) Execute "select pg_sleep(1000);"

3) Open pgAdmin4

4) Connect to respective server

5) Click on Dashboard

6) Check "Sessions" tab under "Server activity" section then look for active sessions for test database.

7) Click on cancel button and cancel the active session

8) Check psql session now, you will see "ERROR:  canceling statement due to user request"

Some comments:

- The action here is to cancel the active query in the backend, not the session - so messages etc. should say things like "Cancel Active Query?"

 

- The grid should refresh following the cancel operation.

- Can you fix the vertical alignment while you're working on this? The new button really makes the poor alignment stand out.

- This should not be superuser only - regular users should be able to cancel their own queries.

- On PG10, background workers are also shown in the dashboard. Should we prevent attempts to cancel their work (they'll fail anyway I believe). 

Thanks!

 

Sure, I'll work on these comments & send updated patch. 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' kind of feature or can this wait for some user validation on a mock up first? 

On Jul 24, 2017, at 20:41, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Sure.

RM created: https://redmine.postgresql.org/issues/2597.

On Mon, Jul 24, 2017 at 6:04 PM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Jul 24, 2017 at 1:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

On Mon, Jul 24, 2017 at 4:44 PM, Dave Page <dpage@pgadmin.org> wrote:

Thanks, applied.

How much effort do you think it would take to turn the table into a subnode control so we can show the SQL query and other missing fields from pg_stat_activity on that tab?

I think around 2-3 days would be needed. 

OK - can you add a Redmine and work on that please? It's been a known deficiency for quite a while, and whilst working on this patch I realised just how badly we really need to see the SQL there.

Thanks.

 

 

On Mon, Jul 24, 2017 at 11:45 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

Please find updated patch.

On Tue, Jul 18, 2017 at 8:05 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Shirley,

On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang <swang@pivotal.io> wrote:

Hi!

I can't seem to get the patch to completely work on my computer, only the close icon shows up plus the dialog and success/error messages, but here are some comments:

Because  we are just cancelling the active running query, so if the start of the session is 'Active' when you cancel it will simply goto 'Idle' stat. 

+1 to Dave's comment about refreshing after the cancel operation

I'll fix this. 

- We're working on a patch for updating alerts in the Dashboard tab which updates the grays in the Database activities panel and changes the border around the refresh button and search bar to 1px. This hasn't been submitted yet but just a heads up as you work on the alignment.

- Something to consider is how a super user will identify which session should be closed. Is that information there?

I think super user can cancel everything except main connection session & as Dave mentioned in previous email that background workers in PG10. 

- Are there sessions that should never be closed? If so, do they also need close buttons? (Probably not, because that will lead the user to an error message, which is not fun)

In Backgrid, we can not exclude specific column from certain rows if it renders in one row then it will render for every row in the grid, What we can do is, it will throw an error when user is not eligible to cancel the active running query. 

- Perhaps this is a good feature to review with Chethana! :)

On Mon, Jul 17, 2017 at 5:37 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

On Mon, Jul 17, 2017 at 3:01 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

hiHi,

PFA patch to add functionality which will allow super user to cancel long running queries from dashboard.

RM#1812

Steps used to test:

1) Open psql session, Connect to 'test' database on respective server

2) Execute "select pg_sleep(1000);"

3) Open pgAdmin4

4) Connect to respective server

5) Click on Dashboard

6) Check "Sessions" tab under "Server activity" section then look for active sessions for test database.

7) Click on cancel button and cancel the active session

8) Check psql session now, you will see "ERROR:  canceling statement due to user request"

Some comments:

- The action here is to cancel the active query in the backend, not the session - so messages etc. should say things like "Cancel Active Query?"

 

- The grid should refresh following the cancel operation.

- Can you fix the vertical alignment while you're working on this? The new button really makes the poor alignment stand out.

- This should not be superuser only - regular users should be able to cancel their own queries.

- On PG10, background workers are also shown in the dashboard. Should we prevent attempts to cancel their work (they'll fail anyway I believe). 

Thanks!

 

Sure, I'll work on these comments & send updated patch. 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang <swang@pivotal.io> wrote:

2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' kind of feature or can this wait for some user validation on a mock up first? 

Most of the time will likely be on the infrastructure to change the display to a subnode control. If you have some cycles to mockup potential layouts for the subnode view and have them validated, please feel free, however, that seems like an awful lot of work to me to display some missing SQL using a standard control.

 

On Jul 24, 2017, at 20:41, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Sure.

RM created: https://redmine.postgresql.org/issues/2597.

On Mon, Jul 24, 2017 at 6:04 PM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Jul 24, 2017 at 1:12 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

On Mon, Jul 24, 2017 at 4:44 PM, Dave Page <dpage@pgadmin.org> wrote:

Thanks, applied.

How much effort do you think it would take to turn the table into a subnode control so we can show the SQL query and other missing fields from pg_stat_activity on that tab?

I think around 2-3 days would be needed. 

OK - can you add a Redmine and work on that please? It's been a known deficiency for quite a while, and whilst working on this patch I realised just how badly we really need to see the SQL there.

Thanks.

 

 

On Mon, Jul 24, 2017 at 11:45 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

Please find updated patch.

On Tue, Jul 18, 2017 at 8:05 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Shirley,

On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang <swang@pivotal.io> wrote:

Hi!

I can't seem to get the patch to completely work on my computer, only the close icon shows up plus the dialog and success/error messages, but here are some comments:

Because  we are just cancelling the active running query, so if the start of the session is 'Active' when you cancel it will simply goto 'Idle' stat. 

+1 to Dave's comment about refreshing after the cancel operation

I'll fix this. 

- We're working on a patch for updating alerts in the Dashboard tab which updates the grays in the Database activities panel and changes the border around the refresh button and search bar to 1px. This hasn't been submitted yet but just a heads up as you work on the alignment.

- Something to consider is how a super user will identify which session should be closed. Is that information there?

I think super user can cancel everything except main connection session & as Dave mentioned in previous email that background workers in PG10. 

- Are there sessions that should never be closed? If so, do they also need close buttons? (Probably not, because that will lead the user to an error message, which is not fun)

In Backgrid, we can not exclude specific column from certain rows if it renders in one row then it will render for every row in the grid, What we can do is, it will throw an error when user is not eligible to cancel the active running query. 

- Perhaps this is a good feature to review with Chethana! :)

On Mon, Jul 17, 2017 at 5:37 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

On Mon, Jul 17, 2017 at 3:01 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

hiHi,

PFA patch to add functionality which will allow super user to cancel long running queries from dashboard.

RM#1812

Steps used to test:

1) Open psql session, Connect to 'test' database on respective server

2) Execute "select pg_sleep(1000);"

3) Open pgAdmin4

4) Connect to respective server

5) Click on Dashboard

6) Check "Sessions" tab under "Server activity" section then look for active sessions for test database.

7) Click on cancel button and cancel the active session

8) Check psql session now, you will see "ERROR:  canceling statement due to user request"

Some comments:

- The action here is to cancel the active query in the backend, not the session - so messages etc. should say things like "Cancel Active Query?"

 

- The grid should refresh following the cancel operation.

- Can you fix the vertical alignment while you're working on this? The new button really makes the poor alignment stand out.

- This should not be superuser only - regular users should be able to cancel their own queries.

- On PG10, background workers are also shown in the dashboard. Should we prevent attempts to cancel their work (they'll fail anyway I believe). 

Thanks!

 

Sure, I'll work on these comments & send updated patch. 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jul 24, 2017 at 8:11 PM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang <swang@pivotal.io> wrote:

2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' kind of feature or can this wait for some user validation on a mock up first? 

Most of the time will likely be on the infrastructure to change the display to a subnode control. If you have some cycles to mockup potential layouts for the subnode view and have them validated, please feel free, however, that seems like an awful lot of work to me to display some missing SQL using a standard control.

Regarding SQL display: Developing simple control to show codemirror in disabled state (for now) wont take that much time.

 

Part of a product designer's job is to make sure there is a definitive need for a feature and that the interface for the feature is designed in such a way that the user gets all intended value from it. Time spent validating now will decrease the time spent later on redesigning / reimplementing.

If everyone is aware of what that value is and confident that how it'll be displayed is right, there's little risk in starting to develop it. If we're wrong, it'll add to feature bloat and detract from the experience.

Hi

I took a quick look at this and have a couple of thoughts:

- Instead of the "edit" icon to open the subnode, we should use something more appropriate - a "properties" icon perhaps.

- There seems to be a lot of different shades of grey on there (maybe a subnode design in general that just shows up with the disabled controls), and the subnode control looks a bit messy as a result.

Can you work with Chethana to improve the look and feel please?

Input from others welcome of course - screenshot attached.

Thanks.

On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

++ Attaching the patch

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

PFA patch to display additional information from pg_stat_activity table using subnode control.

RM#2597

Please review.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang <swang@pivotal.io> wrote:

On Mon, Jul 24, 2017 at 8:11 PM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang <swang@pivotal.io> wrote:

2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' kind of feature or can this wait for some user validation on a mock up first? 

Most of the time will likely be on the infrastructure to change the display to a subnode control. If you have some cycles to mockup potential layouts for the subnode view and have them validated, please feel free, however, that seems like an awful lot of work to me to display some missing SQL using a standard control.

Regarding SQL display: Developing simple control to show codemirror in disabled state (for now) wont take that much time.

 

Part of a product designer's job is to make sure there is a definitive need for a feature and that the interface for the feature is designed in such a way that the user gets all intended value from it. Time spent validating now will decrease the time spent later on redesigning / reimplementing.

If everyone is aware of what that value is and confident that how it'll be displayed is right, there's little risk in starting to develop it. If we're wrong, it'll add to feature bloat and detract from the experience.

Would Chethana be able to take on some of the design work? It would be valuable for the dev team to also be part of design process.

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi Dave,

On Fri, Jul 28, 2017 at 4:11 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

I took a quick look at this and have a couple of thoughts:

- Instead of the "edit" icon to open the subnode, we should use something more appropriate - a "properties" icon perhaps.

I used default subnode's edit icon for consistency purpose.

What if we go with caret-right and caret-down icons?

- There seems to be a lot of different shades of grey on there (maybe a subnode design in general that just shows up with the disabled controls), and the subnode control looks a bit messy as a result.

Can you work with Chethana to improve the look and feel please?

Do you mean only colours or subnode control design itself? 

Input from others welcome of course - screenshot attached.

Thanks.

On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

++ Attaching the patch

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

PFA patch to display additional information from pg_stat_activity table using subnode control.

RM#2597

Please review.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang <swang@pivotal.io> wrote:

On Mon, Jul 24, 2017 at 8:11 PM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang <swang@pivotal.io> wrote:

2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' kind of feature or can this wait for some user validation on a mock up first? 

Most of the time will likely be on the infrastructure to change the display to a subnode control. If you have some cycles to mockup potential layouts for the subnode view and have them validated, please feel free, however, that seems like an awful lot of work to me to display some missing SQL using a standard control.

Regarding SQL display: Developing simple control to show codemirror in disabled state (for now) wont take that much time.

 

Part of a product designer's job is to make sure there is a definitive need for a feature and that the interface for the feature is designed in such a way that the user gets all intended value from it. Time spent validating now will decrease the time spent later on redesigning / reimplementing.

If everyone is aware of what that value is and confident that how it'll be displayed is right, there's little risk in starting to develop it. If we're wrong, it'll add to feature bloat and detract from the experience.

Would Chethana be able to take on some of the design work? It would be valuable for the dev team to also be part of design process.

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi Dave,

Could you comment on the new design update for subnode control ?

Attached designs -

1. subnode_current.png -  The existing view

2. subnode_new.png - The updated view

3. current_new.png - Existing and new design placed together for comparison purpose

Below changes done -

1. Reduced number of gray color variations

2. Made more simplified by removing unwanted borders

3. Merged "Arrow Down" background and the body background for more clarity

Please feel free to provide your input on the same.

Regards,

Chethana kumar

On Fri, Jul 28, 2017 at 4:11 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

I took a quick look at this and have a couple of thoughts:

- Instead of the "edit" icon to open the subnode, we should use something more appropriate - a "properties" icon perhaps.

- There seems to be a lot of different shades of grey on there (maybe a subnode design in general that just shows up with the disabled controls), and the subnode control looks a bit messy as a result.

Can you work with Chethana to improve the look and feel please?

Input from others welcome of course - screenshot attached.

Thanks.

On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

++ Attaching the patch

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

PFA patch to display additional information from pg_stat_activity table using subnode control.

RM#2597

Please review.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang <swang@pivotal.io> wrote:

On Mon, Jul 24, 2017 at 8:11 PM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang <swang@pivotal.io> wrote:

2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' kind of feature or can this wait for some user validation on a mock up first? 

Most of the time will likely be on the infrastructure to change the display to a subnode control. If you have some cycles to mockup potential layouts for the subnode view and have them validated, please feel free, however, that seems like an awful lot of work to me to display some missing SQL using a standard control.

Regarding SQL display: Developing simple control to show codemirror in disabled state (for now) wont take that much time.

 

Part of a product designer's job is to make sure there is a definitive need for a feature and that the interface for the feature is designed in such a way that the user gets all intended value from it. Time spent validating now will decrease the time spent later on redesigning / reimplementing.

If everyone is aware of what that value is and confident that how it'll be displayed is right, there's little risk in starting to develop it. If we're wrong, it'll add to feature bloat and detract from the experience.

Would Chethana be able to take on some of the design work? It would be valuable for the dev team to also be part of design process.

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Chethana Kumar

Principal UI/UX Designer

EnterpriseDB Corporation

The Postgres Database Company

P: +91 86981 57146

www.enterprisedb.com

On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:

Hi Dave,

Could you comment on the new design update for subnode control ?

Attached designs -

1. subnode_current.png -  The existing view

2. subnode_new.png - The updated view

3. current_new.png - Existing and new design placed together for comparison purpose

Below changes done -

1. Reduced number of gray color variations

2. Made more simplified by removing unwanted borders

3. Merged "Arrow Down" background and the body background for more clarity

Please feel free to provide your input on the same.

Much nicer in my opinion! Good work.

Anyone else have any comments?

 

Regards,

Chethana kumar

On Fri, Jul 28, 2017 at 4:11 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

I took a quick look at this and have a couple of thoughts:

- Instead of the "edit" icon to open the subnode, we should use something more appropriate - a "properties" icon perhaps.

- There seems to be a lot of different shades of grey on there (maybe a subnode design in general that just shows up with the disabled controls), and the subnode control looks a bit messy as a result.

Can you work with Chethana to improve the look and feel please?

Input from others welcome of course - screenshot attached.

Thanks.

On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

++ Attaching the patch

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

PFA patch to display additional information from pg_stat_activity table using subnode control.

RM#2597

Please review.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang <swang@pivotal.io> wrote:

On Mon, Jul 24, 2017 at 8:11 PM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang <swang@pivotal.io> wrote:

2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' kind of feature or can this wait for some user validation on a mock up first? 

Most of the time will likely be on the infrastructure to change the display to a subnode control. If you have some cycles to mockup potential layouts for the subnode view and have them validated, please feel free, however, that seems like an awful lot of work to me to display some missing SQL using a standard control.

Regarding SQL display: Developing simple control to show codemirror in disabled state (for now) wont take that much time.

 

Part of a product designer's job is to make sure there is a definitive need for a feature and that the interface for the feature is designed in such a way that the user gets all intended value from it. Time spent validating now will decrease the time spent later on redesigning / reimplementing.

If everyone is aware of what that value is and confident that how it'll be displayed is right, there's little risk in starting to develop it. If we're wrong, it'll add to feature bloat and detract from the experience.

Would Chethana be able to take on some of the design work? It would be valuable for the dev team to also be part of design process.

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Chethana Kumar

Principal UI/UX Designer

EnterpriseDB Corporation

The Postgres Database Company

P: +91 86981 57146

www.enterprisedb.com

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thanks, patch applied.

On Wed, Aug 9, 2017 at 12:19 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

Please find the updated patch with new UI style in dashboard subnode control based on Chethana's design suggestion.

@Shirley,

Yes, DBA needs to click on the drop down to expand.

- If we make whole row clickable then how are we going to identify if user is trying to expand the row or trying to cancel the active session? I am asking this because table row <tr> tag comes before table column tag <td> in HTML DOM, so if we have click event listers on both of the tags then how are we going to differentiate the user operation?

- In my opinion, another reason we can not do that on a dashboard grid because it will break the subnode control consistency, If user sees that grid expands on clicking the row they will expect the same behaviour in other grids as well.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Aug 8, 2017 at 7:47 PM, Shirley Wang <swang@pivotal.io> wrote:

Nice! 

Would a DBA need to click on the drop down to expand? I think that drop down icon might be too small. Perhaps the whole row could be a clickable area to show further details. This is a good thing to test with some people

On Aug 8, 2017, at 12:52, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Mon, Aug 7, 2017 at 9:06 PM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:

Hi Dave,

Could you comment on the new design update for subnode control ?

Attached designs -

1. subnode_current.png -  The existing view

2. subnode_new.png - The updated view

3. current_new.png - Existing and new design placed together for comparison purpose

Below changes done -

1. Reduced number of gray color variations

2. Made more simplified by removing unwanted borders

3. Merged "Arrow Down" background and the body background for more clarity

Please feel free to provide your input on the same.

Much nicer in my opinion! Good work.

Anyone else have any comments?

It looks much nicer.

I would like to see the effect on another dialogs like 'Table properties', where we have multiple level of subgrid controls with tabs.

-- Thanks, Ashesh 

 

Regards,

Chethana kumar

On Fri, Jul 28, 2017 at 4:11 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

I took a quick look at this and have a couple of thoughts:

- Instead of the "edit" icon to open the subnode, we should use something more appropriate - a "properties" icon perhaps.

- There seems to be a lot of different shades of grey on there (maybe a subnode design in general that just shows up with the disabled controls), and the subnode control looks a bit messy as a result.

Can you work with Chethana to improve the look and feel please?

Input from others welcome of course - screenshot attached.

Thanks.

On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

++ Attaching the patch

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

PFA patch to display additional information from pg_stat_activity table using subnode control.

RM#2597

Please review.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang <swang@pivotal.io> wrote:

On Mon, Jul 24, 2017 at 8:11 PM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang <swang@pivotal.io> wrote:

2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' kind of feature or can this wait for some user validation on a mock up first? 

Most of the time will likely be on the infrastructure to change the display to a subnode control. If you have some cycles to mockup potential layouts for the subnode view and have them validated, please feel free, however, that seems like an awful lot of work to me to display some missing SQL using a standard control.

Regarding SQL display: Developing simple control to show codemirror in disabled state (for now) wont take that much time.

 

Part of a product designer's job is to make sure there is a definitive need for a feature and that the interface for the feature is designed in such a way that the user gets all intended value from it. Time spent validating now will decrease the time spent later on redesigning / reimplementing.

If everyone is aware of what that value is and confident that how it'll be displayed is right, there's little risk in starting to develop it. If we're wrong, it'll add to feature bloat and detract from the experience.

Would Chethana be able to take on some of the design work? It would be valuable for the dev team to also be part of design process.

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Chethana Kumar

Principal UI/UX Designer

EnterpriseDB Corporation

The Postgres Database Company

P: +91 86981 57146

www.enterprisedb.com

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company