Обсуждение: [HACKERS] replication_slot_catalog_xmin not explicitly initialized whencreating procArray

Hi,

replication_slot_catalog_xmin is not explictly initialized to InvalidTransactionId.

Normally, there isn't an issue with this because a freshly mmap'd memory is zeroed, and the value of InvalidTransactionId is 0.

If the memory was not 0 for whatever reason, VACUUM would not behave as expected.

See attached patch.

Thanks,

Yi Wen

On Sat, Jul 8, 2017 at 2:19 AM, Wong, Yi Wen <yiwong@amazon.com> wrote:
> Hi,
>
>
> replication_slot_catalog_xmin is not explictly initialized to
> InvalidTransactionId.
>
>
> Normally, there isn't an issue with this because a freshly mmap'd memory is
> zeroed, and the value of InvalidTransactionId is 0.
>
> If the memory was not 0 for whatever reason, VACUUM would not behave as
> expected.
>
>
> See attached patch.
>

Thank you for the patch. This change makes sense to me.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

On 7/9/17 21:23, Masahiko Sawada wrote:
> On Sat, Jul 8, 2017 at 2:19 AM, Wong, Yi Wen <yiwong@amazon.com> wrote:
>> replication_slot_catalog_xmin is not explictly initialized to
>> InvalidTransactionId.

> Thank you for the patch. This change makes sense to me.

Committed and backpatched

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services