Обсуждение: [HACKERS] Fix comment in xlog.c

Attached a patch for $SUBJECT.

- * If RecPtr is not NULL, try to read a record at that position.  Otherwise
+ * If RecPtr is valid, try to read a record at that position.  Otherwise

Commit 4d6d425ab8d addressed the comment above XLogReadRecord() in
xlogreader.c, but missed the same above ReadRecord() in xlog.c.

Backpatchable to 9.3, I'd think.

Thanks,
Amit

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Amit Langote wrote:
> Attached a patch for $SUBJECT.
> 
> - * If RecPtr is not NULL, try to read a record at that position.  Otherwise
> + * If RecPtr is valid, try to read a record at that position.  Otherwise
> 
> Commit 4d6d425ab8d addressed the comment above XLogReadRecord() in
> xlogreader.c, but missed the same above ReadRecord() in xlog.c.
> 
> Backpatchable to 9.3, I'd think.

Yeah, fixed, thanks.



-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On 2017/06/23 5:44, Alvaro Herrera wrote:
> Amit Langote wrote:
>> Attached a patch for $SUBJECT.
>>
>> - * If RecPtr is not NULL, try to read a record at that position.  Otherwise
>> + * If RecPtr is valid, try to read a record at that position.  Otherwise
>>
>> Commit 4d6d425ab8d addressed the comment above XLogReadRecord() in
>> xlogreader.c, but missed the same above ReadRecord() in xlog.c.
>>
>> Backpatchable to 9.3, I'd think.
> 
> Yeah, fixed, thanks.

And thanks too.

Regards,
Amit