Обсуждение: [HACKERS] Typo in xlogfuncs.c [WAS Re: Incorrect mention of pg_xlog_switch() in xlogfuncs.c]

Поиск
Список
Период
Сортировка

[HACKERS] Typo in xlogfuncs.c [WAS Re: Incorrect mention of pg_xlog_switch() in xlogfuncs.c]

От
Neha Khatri
Дата:
Simplifying  $subject. There are typos in xlogfuncs.c. So Either

s/pg_xlog_switch/pg_switch_wal

Or

Remove "pg_xlog_switch" from the comments.

Attached patches both ways.

Regards,
Neha

On Sat, May 20, 2017 at 1:08 AM, Neha Khatri <nehakhatri5@gmail.com> wrote:
While reading some code, noticed that the headers of functions
pg_walfile_name_offset() and pg_walfile_name() incorrecty refer
pg_xlog_switch() since the inception of code in commit 704ddaaa.

In PG10 implementation, actual name of the referred function is
pg_switch_wal(). So either refer the correct name in the function
header or remove the other function referral from the function header.


Вложения

Re: [HACKERS] Typo in xlogfuncs.c [WAS Re: Incorrect mention ofpg_xlog_switch() in xlogfuncs.c]

От
Peter Eisentraut
Дата:
On 5/31/17 19:59, Neha Khatri wrote:
> Simplifying  $subject. There are typos in xlogfuncs.c. So Either
> 
> s/pg_xlog_switch/pg_switch_wal

fixed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services