Обсуждение: [pgsql-www] Code review of the presskits

Поиск
Список
Период
Сортировка

[pgsql-www] Code review of the presskits

От
Daniel Gustafsson
Дата:
When looking at the 9.6 presskit I noticed some incorrect HTML, which led me to
code review the presskits we have for related issues.  The attached patch
includes the following fixes and should bring all presskits to valid XHTML:

* Multiple </a> tags closing a link

* Missing </p> tags leading to nested paragraphs on the next <p>, or one too
  many </p> closing a non-existing paragraph.  Also sometimes empty <p></p>
  blocks.

* Incorrectly spelled tags and entities

* Missing <h1> (due to the <h1> being in the wrong place)

* Updating to use https for links to postgresql.org

* Missing alt=“” on images and unclosed <img> tags

* Missing <h2> for the Graphics section, or the <h2> inside the <a> which is
  illegal in XHTML

* <li> inside a <p>, also without a leading <ul> or <ol>

It’s a rather large patch, but since it’s mainly just a lot of the same I kept
it a single commit.  I can split it up into multiple patches in case that would
aid review.

cheers ./daniel


-- 
Sent via pgsql-www mailing list (pgsql-www@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-www

Вложения

Re: [pgsql-www] Code review of the presskits

От
Magnus Hagander
Дата:
On Wed, May 3, 2017 at 4:26 PM, Daniel Gustafsson <daniel@yesql.se> wrote:
When looking at the 9.6 presskit I noticed some incorrect HTML, which led me to
code review the presskits we have for related issues.  The attached patch
includes the following fixes and should bring all presskits to valid XHTML:

* Multiple </a> tags closing a link

* Missing </p> tags leading to nested paragraphs on the next <p>, or one too
  many </p> closing a non-existing paragraph.  Also sometimes empty <p></p>
  blocks.

* Incorrectly spelled tags and entities

* Missing <h1> (due to the <h1> being in the wrong place)

* Updating to use https for links to postgresql.org

* Missing alt=“” on images and unclosed <img> tags

* Missing <h2> for the Graphics section, or the <h2> inside the <a> which is
  illegal in XHTML

* <li> inside a <p>, also without a leading <ul> or <ol>

It’s a rather large patch, but since it’s mainly just a lot of the same I kept
it a single commit.  I can split it up into multiple patches in case that would
aid review.

Applied, thanks. And yes, single commit is cleaner for something like this I believe. 


--