Обсуждение: [pgadmin-hackers] [PATCH] Allow to skip the feature tests

Hi Dave/Team,

It is not possible to run the regression testsuite on a machine, where chromium driver is not installed with the current implementation, because - we initialize the selenium webdriver on startup without checking whether it is needed, or not.

I have attached the patch to take care of the issue.

It skips the webdriver initialization, and other related parameters, if 'feature_tests' is explicitly added in the exclude package list.

This will allow us to run the regression-suite using the following command without the need of installing the chromedriver on the host machine.

i.e.

python runtests.py --exclude feature_tests

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

Thanks, applied.

On Wed, Mar 8, 2017 at 8:19 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Dave/Team,

It is not possible to run the regression testsuite on a machine, where chromium driver is not installed with the current implementation, because - we initialize the selenium webdriver on startup without checking whether it is needed, or not.

I have attached the patch to take care of the issue.

It skips the webdriver initialization, and other related parameters, if 'feature_tests' is explicitly added in the exclude package list.

This will allow us to run the regression-suite using the following command without the need of installing the chromedriver on the host machine.

i.e.

python runtests.py --exclude feature_tests

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company