Обсуждение: [pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

Поиск
Список
Период
Сортировка

[pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

От
Murtuza Zabuawala
Дата:
Hi,

PFA minor patch to display value '0'  in Read only text editor.
RM#2138


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Вложения

Re: [pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

От
Dave Page
Дата:
Hi

On Wed, Feb 1, 2017 at 12:18 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA minor patch to display value '0'  in Read only text editor.
> RM#2138

Thanks - I committed a modified version of the patch; yours had the
same tests duplicated and joined with an or conditional.

Please double check it's OK - it looks fine to me and seems to work as
expected with null, zero and one.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [pgadmin-hackers] [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

От
Murtuza Zabuawala
Дата:
Thanks Dave.

Tested and working fine.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Wed, Feb 1, 2017 at 7:20 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Feb 1, 2017 at 12:18 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA minor patch to display value '0'  in Read only text editor.
> RM#2138

Thanks - I committed a modified version of the patch; yours had the
same tests duplicated and joined with an or conditional.

Please double check it's OK - it looks fine to me and seems to work as
expected with null, zero and one.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company