Обсуждение: [HACKERS] Fix a comment in feelist.c
Hi,
I've found a mistake in a comment of StrategyNotifyBgWriter
in freelist.c. bgwriterLatch was replaced by bgwprocno in
the following commit, but this is remained in the comment.
commit d72731a70450b5e7084991b9caa15cb58a2820df
Author: Andres Freund <andres@anarazel.de>
Date: Thu Dec 25 18:24:20 2014 +0100
Lockless StrategyGetBuffer clock sweep hot path.
Attached a patch.
--
Yugo Nagata <nagata@sraoss.co.jp>
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Вложения
> I've found a mistake in a comment of StrategyNotifyBgWriter > in freelist.c. bgwriterLatch was replaced by bgwprocno in > the following commit, but this is remained in the comment. > > commit d72731a70450b5e7084991b9caa15cb58a2820df > Author: Andres Freund <andres@anarazel.de> > Date: Thu Dec 25 18:24:20 2014 +0100 > > Lockless StrategyGetBuffer clock sweep hot path. Looks good to me. I will commit/push the patch if there's no objection. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
On Mon, Jan 23, 2017 at 9:47 AM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote: >> I've found a mistake in a comment of StrategyNotifyBgWriter >> in freelist.c. bgwriterLatch was replaced by bgwprocno in >> the following commit, but this is remained in the comment. >> >> commit d72731a70450b5e7084991b9caa15cb58a2820df >> Author: Andres Freund <andres@anarazel.de> >> Date: Thu Dec 25 18:24:20 2014 +0100 >> >> Lockless StrategyGetBuffer clock sweep hot path. > > Looks good to me. > +1. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
>> I've found a mistake in a comment of StrategyNotifyBgWriter >> in freelist.c. bgwriterLatch was replaced by bgwprocno in >> the following commit, but this is remained in the comment. >> >> commit d72731a70450b5e7084991b9caa15cb58a2820df >> Author: Andres Freund <andres@anarazel.de> >> Date: Thu Dec 25 18:24:20 2014 +0100 >> >> Lockless StrategyGetBuffer clock sweep hot path. > > Looks good to me. I will commit/push the patch if there's no > objection. Committed/pushed to all supported branches. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp