Обсуждение: [Patch][pgAdmin4]: RM#1577 - Debug option for function/procedure under package node

Поиск
Список
Период
Сортировка

[Patch][pgAdmin4]: RM#1577 - Debug option for function/procedure under package node

От
Neel Patel
Дата:
Hi,

Please find attached patch file which contains function/procedure debug support under package node. (RM #1577)

Do review it and let me know for any comments.

Thanks,
Neel Patel
Вложения

Re: [Patch][pgAdmin4]: RM#1577 - Debug option for function/procedure under package node

От
Dave Page
Дата:
Thanks, applied. Couple of questions/points:

- If there is no body for a procedure, the error is handled somewhat
ungracefully - the message is displayed without line breaks, and the
debugger panel is left empty. Can we make that a little nicer?

- In pgAdmin 3 there's a "Debug package initialiser?" option on the
parameter dialogue. Is that shown for appropriate packages? I don't
have an example to hand to test with.


On Fri, Oct 7, 2016 at 11:55 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi,
>
> Please find attached patch file which contains function/procedure debug
> support under package node. (RM #1577)
>
> Do review it and let me know for any comments.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [Patch][pgAdmin4]: RM#1577 - Debug option for function/procedure under package node

От
Neel Patel
Дата:
Hi Dave,

On Fri, Oct 7, 2016 at 5:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied. Couple of questions/points:

- If there is no body for a procedure, the error is handled somewhat
ungracefully - the message is displayed without line breaks, and the
debugger panel is left empty. Can we make that a little nicer?
 
OK, I will work on that.

- In pgAdmin 3 there's a "Debug package initialiser?" option on the
parameter dialogue. Is that shown for appropriate packages? I don't
have an example to hand to test with.
 
Currently no option for "Debug package initialiser".
 
I will submit updated patch for both above points.



On Fri, Oct 7, 2016 at 11:55 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi,
>
> Please find attached patch file which contains function/procedure debug
> support under package node. (RM #1577)
>
> Do review it and let me know for any comments.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company