Обсуждение: sloppy handling of pointers

Поиск
Список
Период
Сортировка

sloppy handling of pointers

От
Mark Dilger
Дата:
rangetypes_spgist.c contains a call to detoast a pointer which was
just returned from a detoast operation.  This seems to do no harm,
but is to my mind a sloppy thinko.  Fix attached.

tsgistidx.c contains a detoast of a pointer where detoast of a datum
was likely intended.  Fix attached.

tsrank.c contains some arguably correct casts which I found slightly
less correct than an alternative that I've attached.  I'm pretty indifferent
on this one, and just as happy if it is not included.

Mark Dilger


Вложения

Re: sloppy handling of pointers

От
Jim Nasby
Дата:
On 9/27/16 9:45 PM, Mark Dilger wrote:
> Fix attached.

General comment on all these fixes you're submitting: you'll want to 
submit those to the commitfest app to make sure they get looked at.
-- 
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)   mobile: 512-569-9461