Обсуждение: Wiki problem with URLs
While trying to add a Gmail URL to our TODO wiki: https://wiki.postgresql.org/wiki/Todo I found that URLs that contain equal signs are being silently not displayed by the wiki. For example, this existing TODO entry: {{TodoItem|Allow VIEW/RULE recompilation when the underlying tables change|This is both difficult and controversial.* [http://archives.postgresql.org/pgsql-hackers/2009-12/msg01723.phpRe: About "Allow VIEW/RULE recompilation when the underlyingtables change"]* [http://archives.postgresql.org/pgsql-hackers/2009-12/msg01724.php Re: About "Allow VIEW/RULErecompilation when the underlying tables change"] --> * [http://archives.postgresql.org/message-id/CACk=U9NFSzWrEba8G5dZ=TZLy3_hx3QXGyCcKVWT=4iA1FjMuA@mail.gmail.com VIEWstill referring to old name of field]}} I would love to give you a URL to that section, but "Views / Rules" is not clickable on Firefox on my machine --- you have to scroll down. You will see the text display is: Allow VIEW/RULE recompilation when the underlying tables change The second line is missing, as well as all the links. I believe it is the last link which contains an equals sign that is causing the problem, based on my experiments. A fix need to be found, and all URLs with equal signs fixed. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +
On 01/27/2013 01:02 AM, Bruce Momjian wrote: > While trying to add a Gmail URL to our TODO wiki: > > https://wiki.postgresql.org/wiki/Todo > > I found that URLs that contain equal signs are being silently not > displayed by the wiki. For example, this existing TODO entry: > > {{TodoItem > |Allow VIEW/RULE recompilation when the underlying tables change > |This is both difficult and controversial. > * [http://archives.postgresql.org/pgsql-hackers/2009-12/msg01723.php Re: About "Allow VIEW/RULE recompilation whenthe underlying tables change"] > * [http://archives.postgresql.org/pgsql-hackers/2009-12/msg01724.php Re: About "Allow VIEW/RULE recompilation whenthe underlying tables change"] > --> * [http://archives.postgresql.org/message-id/CACk=U9NFSzWrEba8G5dZ=TZLy3_hx3QXGyCcKVWT=4iA1FjMuA@mail.gmail.comVIEW still referringto old name of field] > }} > > > I would love to give you a URL to that section, but "Views / Rules" is > not clickable on Firefox on my machine --- you have to scroll down. You > will see the text display is: > > Allow VIEW/RULE recompilation when the underlying tables change > > The second line is missing, as well as all the links. I believe it is > the last link which contains an equals sign that is causing the problem, > based on my experiments. > > A fix need to be found, and all URLs with equal signs fixed. well this seems to be a URL encoding issue - replacing the = with a %3D fixes the problem. Stefan
On Sun, Jan 27, 2013 at 07:57:14PM +0100, Stefan Kaltenbrunner wrote: > On 01/27/2013 01:02 AM, Bruce Momjian wrote: > > While trying to add a Gmail URL to our TODO wiki: > > > > https://wiki.postgresql.org/wiki/Todo > > > > I found that URLs that contain equal signs are being silently not > > displayed by the wiki. For example, this existing TODO entry: > > > > {{TodoItem > > |Allow VIEW/RULE recompilation when the underlying tables change > > |This is both difficult and controversial. > > * [http://archives.postgresql.org/pgsql-hackers/2009-12/msg01723.php Re: About "Allow VIEW/RULE recompilation whenthe underlying tables change"] > > * [http://archives.postgresql.org/pgsql-hackers/2009-12/msg01724.php Re: About "Allow VIEW/RULE recompilation whenthe underlying tables change"] > > --> * [http://archives.postgresql.org/message-id/CACk=U9NFSzWrEba8G5dZ=TZLy3_hx3QXGyCcKVWT=4iA1FjMuA@mail.gmail.comVIEW still referringto old name of field] > > }} > > > > > > I would love to give you a URL to that section, but "Views / Rules" is > > not clickable on Firefox on my machine --- you have to scroll down. You > > will see the text display is: > > > > Allow VIEW/RULE recompilation when the underlying tables change > > > > The second line is missing, as well as all the links. I believe it is > > the last link which contains an equals sign that is causing the problem, > > based on my experiments. > > > > A fix need to be found, and all URLs with equal signs fixed. > > > well this seems to be a URL encoding issue - replacing the = with a %3D > fixes the problem. So the only known fix is to hand-edit URLs to use %3D? That doesn't seem very good. Do we need to move the TODO list somewhere else? -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +
Bruce Momjian wrote: > So the only known fix is to hand-edit URLs to use %3D? That doesn't > seem very good. Do we need to move the TODO list somewhere else? There are several reasons why the wiki is not a perfect fit for the TODO; for instance, taking out the items done as each major version gets released is always problematic. Are you proposing to write a Django app to host the TODO? That, I think, would be best. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
On Fri, Feb 1, 2013 at 12:39:42AM -0300, Alvaro Herrera wrote: > Bruce Momjian wrote: > > > So the only known fix is to hand-edit URLs to use %3D? That doesn't > > seem very good. Do we need to move the TODO list somewhere else? > > There are several reasons why the wiki is not a perfect fit for the > TODO; for instance, taking out the items done as each major version gets > released is always problematic. Are you proposing to write a Django app > to host the TODO? That, I think, would be best. Well, I guess all I am saying is that now that there are no archive URLs being generated, e.g. http://archives.postgresql.org/pgsql-hackers/2005-09/msg00781.php everything is a message-id, and many message ids (e.g. Google) have characters that cause problems for the wiki, e.g. '='. I can encode '=', but there might be other characters, and other people might not know to do that. Also, when you don't encode '=', you don't get any feedback that there is a problem --- that link URL just disappears from the wiki, and not just the URL disappears but all links and any secondary text for the item. What I can do it cleanup what is there and try to encode '=', but I hardly see that as a long-term solution. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +
On Fri, Feb 1, 2013 at 12:42:07PM -0500, Bruce Momjian wrote: > What I can do it cleanup what is there and try to encode '=', but I > hardly see that as a long-term solution. FYI, Stefan Kaltenbrunner has already corrected the exiting URLs on the TODO list, so it is just the new ones we need to worry about. I could create an automated script to pull the TODO list and look for '=' in URLs. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +
On 01/27/2013 10:57 AM, Stefan Kaltenbrunner wrote: >> A fix need to be found, and all URLs with equal signs fixed. > > > well this seems to be a URL encoding issue - replacing the = with a %3D > fixes the problem. No it puts a band aid on it. This is clearly a bug in the wiki code. I think it is unreasonable to have to modify every URL that would normally work perfectly. JD -- Command Prompt, Inc. - http://www.commandprompt.com/ PostgreSQL Support, Training, Professional Services and Development High Availability, Oracle Conversion, Postgres-XC @cmdpromptinc - 509-416-6579
On 01/31/2013 07:39 PM, Alvaro Herrera wrote: > > Bruce Momjian wrote: > >> So the only known fix is to hand-edit URLs to use %3D? That doesn't >> seem very good. Do we need to move the TODO list somewhere else? > > There are several reasons why the wiki is not a perfect fit for the > TODO; for instance, taking out the items done as each major version gets > released is always problematic. Are you proposing to write a Django app > to host the TODO? That, I think, would be best. Although it is true that the wiki is not the best choice, it is better than what we had before and this response is certainly not helpful to the problem at hand. JD > -- Command Prompt, Inc. - http://www.commandprompt.com/ PostgreSQL Support, Training, Professional Services and Development High Availability, Oracle Conversion, Postgres-XC @cmdpromptinc - 509-416-6579
On Fri, Feb 1, 2013 at 10:39:05AM -0800, Joshua D. Drake wrote: > > On 01/27/2013 10:57 AM, Stefan Kaltenbrunner wrote: > > >>A fix need to be found, and all URLs with equal signs fixed. > > > > > >well this seems to be a URL encoding issue - replacing the = with a %3D > >fixes the problem. > > No it puts a band aid on it. This is clearly a bug in the wiki code. > I think it is unreasonable to have to modify every URL that would > normally work perfectly. Agreed, but based on the fact that no one yet knows how to fix it, I have written the attached script which I will run automatically to check for such problems. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +