Обсуждение: [PATCHSET] Docs, old build files changes
Hi all I have a set of patches that should be able to be applied without any real concern, to: - Better document arch settings in windows compilation; - Document MSDTC / PGXALIB.DLL tracing - Delete the broken and old Make.bat (and delete MakeX64.bat too, which works but is a THIRD way to build installers - I think powershell and installer.mak is enough). Remove docs that refer to them. - Eliminate the copy and paste coding in the powershell installer creation scripts. Keep the same entry points, but share common code. - Get rid of duplicate readme_winbuild.txt - Remove stray "execute" bits You can pull windows-docs-build-patches for the changes or apply the attached with "git am" (except the execute bits one). I found getting started with psqlODBC rather confusing, because of all the duplicated build options, some of which were broken. This should help a little, though it still leaves NMake and Powershell. Sounds like that can be dealt with after the 0904 release, but this should be safe to patch in before 0904 to make the final 0904 release a bit tidier. Thanks! -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Вложения
Hi, (2014/07/03 15:07), Craig Ringer wrote: > Hi all > > I have a set of patches that should be able to be applied without any > real concern, to: > > - Better document arch settings in windows compilation; Pushd. > - Document MSDTC / PGXALIB.DLL tracing Pushd. > - Delete the broken and old Make.bat (and delete MakeX64.bat too, which > works but is a THIRD way to build installers - I think powershell and > installer.mak is enough). Remove docs that refer to them. Pushd. > - Eliminate the copy and paste coding in the powershell installer > creation scripts. Keep the same entry points, but share common code. It seems better to unify existent scripts using the change. I would do it in a few days. > - Get rid of duplicate readme_winbuild.txt Pushd after I added a reference to the batch files in the folder. > - Remove stray "execute" bits I would push it later. Thanks. Hiroshi Inoue -- I am using the free version of SPAMfighter. SPAMfighter has removed 11329 of my spam emails to date. Get the free SPAMfighter here: http://www.spamfighter.com/len Do you have a slow PC? Try a Free scan http://www.spamfighter.com/SLOW-PCfighter?cid=sigen
On 07/04/2014 11:27 AM, Inoue, Hiroshi wrote: > Pushed. Thanks. >> - Eliminate the copy and paste coding in the powershell installer >> creation scripts. Keep the same entry points, but share common code. > > It seems better to unify existent scripts using the change. > I would do it in a few days. Fair point. I just wanted to stay minimally intrusive. I'm happy to send one that unifies them and takes a "x86" or "x86" argument instead, if you like. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
(2014/07/04 13:45), Craig Ringer wrote: > On 07/04/2014 11:27 AM, Inoue, Hiroshi wrote: >> Pushed. > > Thanks. > >>> - Eliminate the copy and paste coding in the powershell installer >>> creation scripts. Keep the same entry points, but share common code. >> >> It seems better to unify existent scripts using the change. >> I would do it in a few days. > > Fair point. I just wanted to stay minimally intrusive. > > I'm happy to send one that unifies them and takes a "x86" or "x86" > argument instead, if you like. Hmm there's a possibilty that it would be deleted even though you make it. It's OK? regards, Hiroshi Inoue -- I am using the free version of SPAMfighter. SPAMfighter has removed 11419 of my spam emails to date. Get the free SPAMfighter here: http://www.spamfighter.com/len Do you have a slow PC? Try a Free scan http://www.spamfighter.com/SLOW-PCfighter?cid=sigen
On 07/07/2014 11:43 AM, Inoue, Hiroshi wrote: >> >> Fair point. I just wanted to stay minimally intrusive. >> >> I'm happy to send one that unifies them and takes a "x86" or "x86" >> argument instead, if you like. > > Hmm there's a possibilty that it would be deleted even though you make > it. It's OK? I don't understand. Do you mean with the move to the new build after 9.4 release possibly getting rid of the Powershell stuff? If so, good point. Probably not worth the time and effort. Maybe it's better to just merge the patch as written. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
(2014/07/07 13:11), Craig Ringer wrote: > On 07/07/2014 11:43 AM, Inoue, Hiroshi wrote: >>> >>> Fair point. I just wanted to stay minimally intrusive. >>> >>> I'm happy to send one that unifies them and takes a "x86" or "x86" >>> argument instead, if you like. >> >> Hmm there's a possibilty that it would be deleted even though you make >> it. It's OK? > > I don't understand. > > Do you mean with the move to the new build after 9.4 release possibly > getting rid of the Powershell stuff? Yes though I don't prefer Heikki's proposal. > If so, good point. Probably not worth the time and effort. Maybe it's > better to just merge the patch as written. Hmm it seems simpler to unify them than merging and I already made it. regards, Hiroshi Inoue -- I am using the free version of SPAMfighter. SPAMfighter has removed 11478 of my spam emails to date. Get the free SPAMfighter here: http://www.spamfighter.com/len Do you have a slow PC? Try a Free scan http://www.spamfighter.com/SLOW-PCfighter?cid=sigen