Обсуждение: installer\Make.bat bitrotted
Hi folks It seems that installer\Make.bat is somewhat bitrotted - it hasn't caught up with the changes in Make64.bat with the x86 and x64 directories. I haven't prepped a patch given the discussion of doing away with the installer\ dir entirely. Think it's worth it? -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
On 07/01/2014 06:15 PM, Craig Ringer wrote: > Hi folks > > It seems that installer\Make.bat is somewhat bitrotted - it hasn't > caught up with the changes in Make64.bat with the x86 and x64 directories. > > I haven't prepped a patch given the discussion of doing away with the > installer\ dir entirely. Think it's worth it? In fact, it's better to delete Make.bat, rename MakeX64.bat to just Make.bat and have it: - Handle spaces in %LIBPQBINDIR% correctly - Accept environment or command line overrides to CPUTYPE then it builds both fine. I'll send a patch; it's trivial enough. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
On 07/02/2014 11:31 PM, Craig Ringer wrote: > On 07/01/2014 06:15 PM, Craig Ringer wrote: >> Hi folks >> >> It seems that installer\Make.bat is somewhat bitrotted - it hasn't >> caught up with the changes in Make64.bat with the x86 and x64 directories. >> >> I haven't prepped a patch given the discussion of doing away with the >> installer\ dir entirely. Think it's worth it? > > > In fact, it's better to delete Make.bat, rename MakeX64.bat to just > Make.bat and have it: > > - Handle spaces in %LIBPQBINDIR% correctly > > - Accept environment or command line overrides to CPUTYPE > > then it builds both fine. Hm, also needs the product code changed. > I'll send a patch; it's trivial enough. Actually, no I won't. Both should be deleted. The powershell scripts work. Why have both? -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services