Обсуждение: psqlODBC 09.03.0300 Released
Hi, all. We are release of psqlODBC 09.03.0300. this is a some bugfix release. please see the notes at: http://psqlodbc.projects.pgfoundry.org/ psqlODBC may be downloaded from http://www.postgresql.org/ftp/odbc/versions/ in source, Windows Installer, merge module, and basic zip file formats. Please post any bug reports to the pgsql-odbc@postgresql.org mailing list. I'd like to take this opportunity to thank all those involved with the development, testing and bug fixing of the updated driver. We are grateful to the help of many peoples. Thanks! -- psqlODBC team.
Re: Hiroshi Saito 2014-05-18 <537816AF.2070308@winpg.jp> > Hi, all. > > We are release of psqlODBC 09.03.0300. this is a some bugfix release. > please see the notes at: > http://psqlodbc.projects.pgfoundry.org/ Hi, the release notes at http://psqlodbc.projects.pgfoundry.org/docs/release.html have not been updated yet. I'm also getting regression failures: ============== running regression test queries ============== test sampletables ... ok test connect ... ok test stmthandles ... ok test select ... ok test commands ... ok test multistmt ... ok test getresult ... ok test prepare ... ok test params ... ok test notice ... ok test arraybinding ... ok test insertreturning ... ok test dataatexecution ... ok test boolsaschar ... ok test cvtnulldate ... ok test alter ... ok test quotes ... ok test cursors ... ok test positioned-update ... ok test catalogfunctions ... FAILED test bindcol ... ok test lfconversion ... ok test cte ... ok test deprecated ... ok test error-rollback ... ok test diagnostic ... ok ======================= 1 of 26 tests failed. ======================= The differences that caused some tests to fail can be viewed in the file "/srv/projects/postgresql/psqlodbc/psqlodbc/test/regression.diffs". A copy of the test summary that you see above is saved in the file "/srv/projects/postgresql/psqlodbc/psqlodbc/test/regression.out". make[1]: *** [installcheck] Fehler 1 make[1]: Leaving directory `/srv/projects/postgresql/psqlodbc/psqlodbc/test' regression.diffs: *** /srv/projects/postgresql/psqlodbc/psqlodbc/test/expected/catalogfunctions.out 2014-05-17 14:33:40.000000000 +0200 --- /srv/projects/postgresql/psqlodbc/psqlodbc/test/results/catalogfunctions.out 2014-05-25 23:05:55.990780975 +0200 *************** *** 186,196 **** contrib_regression public testtab1 _SYSTEM UPDATE YES contrib_regression public testtab1 _SYSTEM DELETE YES contrib_regression public testtab1 _SYSTEM REFERENCES YES - contrib_regression public testtab1 _SYSTEM INSERT YES - contrib_regression public testtab1 _SYSTEM SELECT YES - contrib_regression public testtab1 _SYSTEM UPDATE YES - contrib_regression public testtab1 _SYSTEM DELETE YES - contrib_regression public testtab1 _SYSTEM REFERENCES YES Result set: contrib_regression public testtab1 TABLE contrib_regression public testtab_fk TABLE The missing lines were introduced in ad2a4aecb4748f8c5280aabf65dae570a9529065. Possibly the generator for these wasn't updated/committed along? Christoph -- cb@df7cb.de | http://www.df7cb.de/
On Mon, May 26, 2014 at 6:17 AM, Christoph Berg <cb@df7cb.de> wrote: > Re: Hiroshi Saito 2014-05-18 <537816AF.2070308@winpg.jp> > ============== running regression test queries ============== > test catalogfunctions ... FAILED > The missing lines were introduced in > ad2a4aecb4748f8c5280aabf65dae570a9529065. Possibly the generator for > these wasn't updated/committed along? This is being discussed here as well: http://www.postgresql.org/message-id/CAB7nPqQN=CB2HXwB5DRAgHwhMnHQBHh2QaNPFbMB+z_ohsVY_w@mail.gmail.com I think that this portion of the commit should be reverted. Saito-san also did not provide the conditions (OS, configuration) under which he can reproduce this error. Output as it stands now is wrong btw as SQLPrivileges should not return the same privileges twice for the same table... -- Michael
On 05/26/2014 02:11 AM, Michael Paquier wrote: > On Mon, May 26, 2014 at 6:17 AM, Christoph Berg <cb@df7cb.de> wrote: >> Re: Hiroshi Saito 2014-05-18 <537816AF.2070308@winpg.jp> >> ============== running regression test queries ============== >> test catalogfunctions ... FAILED >> The missing lines were introduced in >> ad2a4aecb4748f8c5280aabf65dae570a9529065. Possibly the generator for >> these wasn't updated/committed along? > This is being discussed here as well: > http://www.postgresql.org/message-id/CAB7nPqQN=CB2HXwB5DRAgHwhMnHQBHh2QaNPFbMB+z_ohsVY_w@mail.gmail.com > I think that this portion of the commit should be reverted. Saito-san > also did not provide the conditions (OS, configuration) under which he > can reproduce this error. > > Output as it stands now is wrong btw as SQLPrivileges should not > return the same privileges twice for the same table... Yeah, it's definitely wrong as it is. Since we haven't heard from Saito-san why he did that, I'm assuming it was an oversight. I just reverted the bogus change to the expected output, so it should work now. - Heikki
On 05/26/2014 12:17 AM, Christoph Berg wrote: > Re: Hiroshi Saito 2014-05-18 <537816AF.2070308@winpg.jp> >> Hi, all. >> >> We are release of psqlODBC 09.03.0300. this is a some bugfix release. >> please see the notes at: >> http://psqlodbc.projects.pgfoundry.org/ > > Hi, > > the release notes at > http://psqlodbc.projects.pgfoundry.org/docs/release.html have not been > updated yet. Thanks, fixed. - Heikki
On Tue, May 27, 2014 at 10:20 PM, Heikki Linnakangas <hlinnakangas@vmware.com> wrote: > Yeah, it's definitely wrong as it is. Since we haven't heard from Saito-san > why he did that, I'm assuming it was an oversight. I just reverted the bogus > change to the expected output, so it should work now. Thanks! -- Michael
On Tuesday 27 of May 2014 16:20:49 Heikki Linnakangas wrote: > On 05/26/2014 02:11 AM, Michael Paquier wrote: > > On Mon, May 26, 2014 at 6:17 AM, Christoph Berg <cb@df7cb.de> wrote: > >> Re: Hiroshi Saito 2014-05-18 <537816AF.2070308@winpg.jp> > >> ============== running regression test queries ============== > >> test catalogfunctions ... FAILED > >> The missing lines were introduced in > >> ad2a4aecb4748f8c5280aabf65dae570a9529065. Possibly the generator for > >> these wasn't updated/committed along? > > This is being discussed here as well: > > http://www.postgresql.org/message-id/CAB7nPqQN=CB2HXwB5DRAgHwhMnHQBHh2QaNPFbMB+z_ohsVY_w@mail.gmail.com > > I think that this portion of the commit should be reverted. Saito-san > > also did not provide the conditions (OS, configuration) under which he > > can reproduce this error. > > > > Output as it stands now is wrong btw as SQLPrivileges should not > > return the same privileges twice for the same table... > > Yeah, it's definitely wrong as it is. Since we haven't heard from > Saito-san why he did that, I'm assuming it was an oversight. I just > reverted the bogus change to the expected output, so it should work now. FWIW, tested with PostgreSQL 9.3.5 and I see there the privileges twice, there are not same though. I tried this: diff --git a/src/catalogfunctions-test.c b/src/catalogfunctions-test.c index d2fbc34..2ff162d 100644 --- a/src/catalogfunctions-test.c +++ b/src/catalogfunctions-test.c @@ -25,7 +25,7 @@ main(int argc, char **argv) int rc; HSTMT hstmt = SQL_NULL_HSTMT; /* Cases where output is limited to relevant information only */ - SQLSMALLINT sql_tab_privileges_ids[6] = {1, 2, 3, 4, 6, 7}; + SQLSMALLINT sql_tab_privileges_ids[7] = {1, 2, 3, 4, 5, 6, 7}; SQLSMALLINT sql_column_ids[6] = {1, 2, 3, 4, 5, 6}; test_connect(); @@ -180,7 +180,7 @@ main(int argc, char **argv) (SQLCHAR *) "testtab1", SQL_NTS); CHECK_STMT_RESULT(rc, "SQLTablePrivileges failed", hstmt); print_result_meta(hstmt); - print_result_series(hstmt, sql_tab_privileges_ids, 6); + print_result_series(hstmt, sql_tab_privileges_ids, 7); rc = SQLFreeStmt(hstmt, SQL_CLOSE); CHECK_STMT_RESULT(rc, "SQLFreeStmt failed", hstmt); And I got this: *** /tmp/odbc-test/upstream/test/expected/catalogfunctions.out 2014-11-18 12:23:24.000000000 +0100 --- /tmp/odbc-test/upstream/test/results/catalogfunctions.out 2014-11-18 15:18:03.530186354 +0100 *************** *** 184,194 **** PRIVILEGE: VARCHAR(128) digits: 0, nullable IS_GRANTABLE: VARCHAR(128) digits: 0, nullable Result set: ! contrib_regression public testtab1 _SYSTEM INSERT YES ! contrib_regression public testtab1 _SYSTEM SELECT YES ! contrib_regression public testtab1 _SYSTEM UPDATE YES ! contrib_regression public testtab1 _SYSTEM DELETE YES ! contrib_regression public testtab1 _SYSTEM REFERENCES YES Result set: contrib_regression public testtab1 TABLE contrib_regression public testtab_fk TABLE --- 184,199 ---- PRIVILEGE: VARCHAR(128) digits: 0, nullable IS_GRANTABLE: VARCHAR(128) digits: 0, nullable Result set: ! contrib_regression public testtab1 _SYSTEM postgres INSERT YES ! contrib_regression public testtab1 _SYSTEM postgres SELECT YES ! contrib_regression public testtab1 _SYSTEM postgres UPDATE YES ! contrib_regression public testtab1 _SYSTEM postgres DELETE YES ! contrib_regression public testtab1 _SYSTEM postgres REFERENCES YES ! contrib_regression public testtab1 _SYSTEM test INSERT YES ! contrib_regression public testtab1 _SYSTEM test SELECT YES ! contrib_regression public testtab1 _SYSTEM test UPDATE YES ! contrib_regression public testtab1 _SYSTEM test DELETE YES ! contrib_regression public testtab1 _SYSTEM test REFERENCES YES Result set: contrib_regression public testtab1 TABLE contrib_regression public testtab_fk TABLE ====================================================================== Seems like the testsuite is _required_ to be run under 'postgres' user, isn't it truth? Pavel