Обсуждение: EN_Destructor bug?

Поиск
Список
Период
Сортировка

EN_Destructor bug?

От
Tom Hughes
Дата:
When EN_Destructor is called it searches through the connection array
and destroys any connections which belong that environment. Unfortunately
it doesn't NULL out the connection array entry afterwards so a future
call to EN_Destructor can wind up trying to destroy that connection
again if another environment has been allocated at the same address.

Also, shouldn't EN_Destructor hold the CONNS critical section while it
is playing with the connection array?

The attached patch fixes both of these issues and seems to have fixed
the crashes I was observing.

Tom

--
Tom Hughes (thh@cyberscience.com)
Software Engineer, Cyberscience Corporation
http://www.cyberscience.com/


Вложения

Re: EN_Destructor bug?

От
"Dave Page"
Дата:
Thanks Tom, patch applied.

Regards, Dave

> -----Original Message-----
> From: pgsql-odbc-owner@postgresql.org
> [mailto:pgsql-odbc-owner@postgresql.org] On Behalf Of Tom Hughes
> Sent: 19 October 2005 15:07
> To: pgsql-odbc@postgresql.org
> Subject: [ODBC] EN_Destructor bug?
>
> When EN_Destructor is called it searches through the connection array
> and destroys any connections which belong that environment.
> Unfortunately
> it doesn't NULL out the connection array entry afterwards so a future
> call to EN_Destructor can wind up trying to destroy that connection
> again if another environment has been allocated at the same address.
>
> Also, shouldn't EN_Destructor hold the CONNS critical section while it
> is playing with the connection array?
>
> The attached patch fixes both of these issues and seems to have fixed
> the crashes I was observing.
>
> Tom
>
> --
> Tom Hughes (thh@cyberscience.com)
> Software Engineer, Cyberscience Corporation
> http://www.cyberscience.com/
>
>