Обсуждение: RE: RE: [INTERFACES] 7.1 beta 3 Linux ODBC BEGINBehaviour

> -----Original Message-----
> From: Dave Page [mailto:dpage@vale-housing.co.uk]
> Sent: 13 February 2001 15:20
> To: 'Tom Lane'
> Cc: 'Hiroshi Inoue'; pgsql-odbc@postgresql.org
> Subject: RE: [ODBC] RE: [INTERFACES] 7.1 beta 3 Linux ODBC
> BEGINBehaviour
>
>
>
>
> > -----Original Message-----
> > From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> > Sent: 13 February 2001 14:58
> > To: Dave Page
> > Cc: 'Hiroshi Inoue'; Steve Wranovsky;
> pgsql-interfaces@postgresql.org;
> > pgsql-odbc@postgresql.org
> > Subject: Re: [ODBC] RE: [INTERFACES] 7.1 beta 3 Linux ODBC
> > BEGINBehaviour
> >
> >
> > Dave Page <dpage@vale-housing.co.uk> writes:
> > > Incidently, pgAdmin gets round the problem by prepending a
> > space to affected
> > > queries! It seems that postgresql will error with
> "VACUUM" but not "
> > > VACUUM". Odd....
> >
> > Postgres itself doesn't care.  However, up till a day or two ago the
> > ODBC driver would change its behavior depending on leading spaces.
> >
> > You will probably find that the above-quoted hack no longer works
> > with the current-CVS ODBC driver ...
> >
>
> Awwww nuts! If that's the case pgAdmin has just broken in
> numerous places
> :-(. I'll have to test it...

Just recompiled the driver and it still works :-)

Regards, Dave.

Dave Page <dpage@vale-housing.co.uk> writes:
> Postgres itself doesn't care.  However, up till a day or two ago the
> ODBC driver would change its behavior depending on leading spaces.
>
> You will probably find that the above-quoted hack no longer works
> with the current-CVS ODBC driver ...
>
>>
>> Awwww nuts! If that's the case pgAdmin has just broken in
>> numerous places :-(. I'll have to test it...

> Just recompiled the driver and it still works :-)

Okay.  Now that I look at it, the change I was thinking of wouldn't have
affected the behavior for utility statements anyway.  What was broken
was statement_type() in statement.c --- it would fail to recognize any
statement with leading spaces, and would always return STMT_TYPE_OTHER.
But that is the right answer for VACUUM and suchlike.  The case it
really crashed and burned on was SELECT with leading spaces...

            regards, tom lane