Обсуждение: Re: [COMMITTERS] pgsql: Modify BufferGetPage() to prepare for "snapshot too old" feature

Kevin Grittner wrote:
> Modify BufferGetPage() to prepare for "snapshot too old" feature

I just noticed that this commit added a line to #include catalog/catalog.h
in storage/bufmgr.h.  I can't find any reason for it doing so, and I
think it's a bad line to have there.  Can we get it removed?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On Wed, Aug 24, 2016 at 12:40 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Kevin Grittner wrote:
>> Modify BufferGetPage() to prepare for "snapshot too old" feature
>
> I just noticed that this commit added a line to #include catalog/catalog.h
> in storage/bufmgr.h.  I can't find any reason for it doing so, and I
> think it's a bad line to have there.  Can we get it removed?

Will do that now.  It was initially added because
IsCatalogRelation() was referenced in storage/bufmgr.h, but for
various reasons it seemed better to move that, and I missed the
include.  Thanks for spotting it.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Aug 24, 2016 at 1:00 PM, Kevin Grittner <kgrittn@gmail.com> wrote:
> On Wed, Aug 24, 2016 at 12:40 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

>> #include catalog/catalog.h in storage/bufmgr.h.

>> Can we get it removed?
>
> Will do that now.

Done.  Back-patched to 9.6 (although I see I forgot to mention that
in the commit message).

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company