Обсуждение: new pgindent run before branch?
Hi, Would anyone mind too much if I refreshed typedefs.list and re-indented the whole tree before we branch? There's not too much churn at the moment, and I feel like it would be nice to start the cycle in as clean a state as possible. Current results of this attached. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Вложения
On Wed, Aug 10, 2016 at 04:02:27PM -0400, Robert Haas wrote: > Hi, > > Would anyone mind too much if I refreshed typedefs.list and > re-indented the whole tree before we branch? There's not too much > churn at the moment, and I feel like it would be nice to start the > cycle in as clean a state as possible. > > Current results of this attached. Sure, seems like a good idea. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
Robert Haas <robertmhaas@gmail.com> writes:
> Would anyone mind too much if I refreshed typedefs.list and
> re-indented the whole tree before we branch?
+1, I was planning to do that myself.
regards, tom lane
On Wed, Aug 10, 2016 at 5:04 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Robert Haas <robertmhaas@gmail.com> writes: >> Would anyone mind too much if I refreshed typedefs.list and >> re-indented the whole tree before we branch? > > +1, I was planning to do that myself. Great. Are you handling creating the new branch? If so, it probably makes sense for you to do this just beforehand. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Aug 10, 2016 at 5:04 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> Would anyone mind too much if I refreshed typedefs.list and
>>> re-indented the whole tree before we branch?
>> +1, I was planning to do that myself.
> Great. Are you handling creating the new branch?
Yeah, I guess. I've made most of them lately.
> If so, it probably
> makes sense for you to do this just beforehand.
OK.
regards, tom lane
On Wed, Aug 10, 2016 at 10:23:14PM -0400, Tom Lane wrote: > Robert Haas <robertmhaas@gmail.com> writes: > > On Wed, Aug 10, 2016 at 5:04 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > >> Robert Haas <robertmhaas@gmail.com> writes: > >>> Would anyone mind too much if I refreshed typedefs.list and > >>> re-indented the whole tree before we branch? > > >> +1, I was planning to do that myself. > > > Great. Are you handling creating the new branch? > > Yeah, I guess. I've made most of them lately. > > > If so, it probably > > makes sense for you to do this just beforehand. > > OK. I am confused --- are you pgindenting just HEAD and not 9.6? Why? -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
Bruce Momjian <bruce@momjian.us> writes:
> I am confused --- are you pgindenting just HEAD and not 9.6? Why?
The point is to pgindent while they're still the same.
regards, tom lane
On Wed, Aug 10, 2016 at 10:31:35PM -0400, Tom Lane wrote: > Bruce Momjian <bruce@momjian.us> writes: > > I am confused --- are you pgindenting just HEAD and not 9.6? Why? > > The point is to pgindent while they're still the same. So I read this: > >> +1, I was planning to do that myself. > > > Great. Are you handling creating the new branch? > > Yeah, I guess. I've made most of them lately. > > > If so, it probably > > makes sense for you to do this just beforehand. > > OK. It sounds like you are saying that the branch is to happen before the pgindent run. Am I missing something? -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
Bruce Momjian <bruce@momjian.us> writes:
> It sounds like you are saying that the branch is to happen before the
> pgindent run. Am I missing something?
I read it as pgindent then branch.
regards, tom lane
On Wed, Aug 10, 2016 at 10:35:44PM -0400, Tom Lane wrote: > Bruce Momjian <bruce@momjian.us> writes: > > It sounds like you are saying that the branch is to happen before the > > pgindent run. Am I missing something? > > I read it as pgindent then branch. OK, good. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
On Wed, Aug 10, 2016 at 10:23 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Great. Are you handling creating the new branch? > > Yeah, I guess. I've made most of them lately. I'll do it if you want. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company