Обсуждение: use of SEQ_MINVALUE in btree_gin

Поиск
Список
Период
Сортировка

use of SEQ_MINVALUE in btree_gin

От
Peter Eisentraut
Дата:
btree_gin uses SEQ_MINVALUE as a way to get the smallest int64 value.
This is actually wrong because the smallest int64 value is
SEQ_MINVALUE-1, so this might be slightly broken.

The whole thing was done as a convenience when INT64_IS_BUSTED had to be
considered, but I think we can get rid of that now.  See attached
proposed patch.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Вложения

Re: use of SEQ_MINVALUE in btree_gin

От
Tom Lane
Дата:
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> btree_gin uses SEQ_MINVALUE as a way to get the smallest int64 value.
> This is actually wrong because the smallest int64 value is
> SEQ_MINVALUE-1, so this might be slightly broken.

> The whole thing was done as a convenience when INT64_IS_BUSTED had to be
> considered, but I think we can get rid of that now.  See attached
> proposed patch.

+1.  I agree that this is actually a bug fix, so it should be back-patched.
        regards, tom lane