Обсуждение: Re: tsearch_extras extension

Поиск
Список
Период
Сортировка

Re: tsearch_extras extension

От
Tim Abbott
Дата:
Just following up here since I haven't gotten a reply -- I'd love to work with someone from the Postgres community on a plan to make the tsearch_extras functionality available as part of mainline postgres.


        -Tim Abbott

On Wed, Feb 3, 2016 at 9:41 PM, Tim Abbott <tabbott@mit.edu> wrote:
Hello,

I'm a maintainer of the Zulip open source group chat application.  Zulip depends on a small (~200 lines) postgres extension called tsearch_extras (https://github.com/zbenjamin/tsearch_extras) that returns the actual (offset, length) pairs of all the matches for a postgres full text search query.  This extension allows Zulip to do its own highlighting of the full text search matches, using a more complicated method than what Postgres supports natively.  

I think tsearch_extras is probably of value to others using postgres full-text search (and I'd certainly love to get out of the business of maintaining an out-of-tree postgres extension), so I'm wondering if this feature (or a variant of it) would be of interest to upstream?  

Thanks!

        -Tim Abbott

(See http://www.postgresql.org/message-id/flat/52C7186D.8010504@strangersgate.com#52C7186D.8010504@strangersgate.com for the discussion on postgres mailing lists that caused us to write this module in the first place.)


Re: tsearch_extras extension

От
Oleg Bartunov
Дата:


On Wed, Feb 17, 2016 at 6:57 AM, Tim Abbott <tabbott@mit.edu> wrote:
Just following up here since I haven't gotten a reply -- I'd love to work with someone from the Postgres community on a plan to make the tsearch_extras functionality available as part of mainline postgres.


        -Tim Abbott

On Wed, Feb 3, 2016 at 9:41 PM, Tim Abbott <tabbott@mit.edu> wrote:
Hello,

I'm a maintainer of the Zulip open source group chat application.  Zulip depends on a small (~200 lines) postgres extension called tsearch_extras (https://github.com/zbenjamin/tsearch_extras) that returns the actual (offset, length) pairs of all the matches for a postgres full text search query.  This extension allows Zulip to do its own highlighting of the full text search matches, using a more complicated method than what Postgres supports natively.  

I think tsearch_extras is probably of value to others using postgres full-text search (and I'd certainly love to get out of the business of maintaining an out-of-tree postgres extension), so I'm wondering if this feature (or a variant of it) would be of interest to upstream?  

Thanks!

        -Tim Abbott

(See http://www.postgresql.org/message-id/flat/52C7186D.8010504@strangersgate.com#52C7186D.8010504@strangersgate.com for the discussion on postgres mailing lists that caused us to write this module in the first place.)

Tim,

take a look on this patch (https://commitfest.postgresql.org/7/385/) and contact author.  It contains everything you need to your purposes.

btw, Stas, check on status "Returned with feedback" !


Regards,
Oleg

Re: tsearch_extras extension

От
Stas Kelvich
Дата:
> On 17 Feb 2016, at 08:14, Oleg Bartunov <obartunov@gmail.com> wrote:
>
>
>
> On Wed, Feb 17, 2016 at 6:57 AM, Tim Abbott <tabbott@mit.edu> wrote:
> Just following up here since I haven't gotten a reply -- I'd love to work with someone from the Postgres community on
aplan to make the tsearch_extras functionality available as part of mainline postgres. 
>
>
>         -Tim Abbott
>
> On Wed, Feb 3, 2016 at 9:41 PM, Tim Abbott <tabbott@mit.edu> wrote:
> Hello,
>
> I'm a maintainer of the Zulip open source group chat application.  Zulip depends on a small (~200 lines) postgres
extensioncalled tsearch_extras (https://github.com/zbenjamin/tsearch_extras) that returns the actual (offset, length)
pairsof all the matches for a postgres full text search query.  This extension allows Zulip to do its own highlighting
ofthe full text search matches, using a more complicated method than what Postgres supports natively.   
>
> I think tsearch_extras is probably of value to others using postgres full-text search (and I'd certainly love to get
outof the business of maintaining an out-of-tree postgres extension), so I'm wondering if this feature (or a variant of
it)would be of interest to upstream?   
>
> Thanks!
>
>         -Tim Abbott
>
> (See http://www.postgresql.org/message-id/flat/52C7186D.8010504@strangersgate.com#52C7186D.8010504@strangersgate.com
forthe discussion on postgres mailing lists that caused us to write this module in the first place.) 
>
> Tim,
>
> take a look on this patch (https://commitfest.postgresql.org/7/385/) and contact author.  It contains everything you
needto your purposes. 
>
> btw, Stas, check on status "Returned with feedback" !
>
>
> Regards,
> Oleg
>

Hi,

Yes, this extension have some common functionality with patch. Particularly yours tsvector_lexemes and mine to_array do
thesame thing. I wasn’t aware of you patch when started to work on that, so I think we can ask commiter to mention you
incommit message (if it that will be commited). 

And how do you use ts_match_locs_array / ts_match_locs_array? To highlight search results? There is function called
ts_headlinethat can mark matches with custom start/stop strings. 

---
Stas Kelvich
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company