Обсуждение: Unused variables in hstore_to_jsonb

Hi all,

Coverity pointed out that hstore_to_jsonb in hstore_io.c does not use
a couple of return values from pushJsonbValue.
Attached is a patch to fix that.
Regards,
--
Michael

On Tue, Jan 13, 2015 at 4:34 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> Attached is a patch to fix that.
Oh, actually that's as well the case of hstore_to_jsonb_loose. Updated
patch is attached.
--
Michael

On 01/13/2015 09:39 AM, Michael Paquier wrote:
> On Tue, Jan 13, 2015 at 4:34 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> Attached is a patch to fix that.
> Oh, actually that's as well the case of hstore_to_jsonb_loose. Updated
> patch is attached.

You'll need to use "(void) pushJsonbValue(...)", otherwise you'll just 
get a different warning. See commit c8315930.

- Heikki

On Tue, Jan 13, 2015 at 5:36 PM, Heikki Linnakangas
<hlinnakangas@vmware.com> wrote:
> You'll need to use "(void) pushJsonbValue(...)", otherwise you'll just get a
> different warning. See commit c8315930.
Oh, I see. So this portion in contrib/ has been visibly missing.
Attached is a new patch.
--
Michael

On 01/13/2015 01:09 PM, Michael Paquier wrote:
> On Tue, Jan 13, 2015 at 5:36 PM, Heikki Linnakangas
> <hlinnakangas@vmware.com> wrote:
>> You'll need to use "(void) pushJsonbValue(...)", otherwise you'll just get a
>> different warning. See commit c8315930.
> Oh, I see. So this portion in contrib/ has been visibly missing.
> Attached is a new patch.

Thanks, committed.

- Heikki