Обсуждение: event trigger test exception message
I don't wish to seem humorless, but I think this should probably be changed: root/HEAD/pgsql/src/test/regress/sql/event_trigger.sql:248: RAISE EXCEPTION 'I''m sorry Sir, No Rewrite Allowed.'; Quite apart from any other reason, the "Sir" does seem a bit sexist - we have no idea of the gender of the reader. Probably just 'sorry, no rewrite allowed' would suffice. (Noticed while looking at buildfarm failures.) cheers andrew
Em domingo, 4 de janeiro de 2015, Andrew Dunstan <andrew@dunslane.net> escreveu:
I don't wish to seem humorless, but I think this should probably be changed:
root/HEAD/pgsql/src/test/regress/sql/event_trigger.sql:248: RAISE EXCEPTION 'I''m sorry Sir, No Rewrite Allowed.';
Quite apart from any other reason, the "Sir" does seem a bit sexist - we have no idea of the gender of the reader. Probably just 'sorry, no rewrite allowed' would suffice.
+1
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello
Andrew Dunstan wrote: > > I don't wish to seem humorless, but I think this should probably be changed: > > root/HEAD/pgsql/src/test/regress/sql/event_trigger.sql:248: RAISE EXCEPTION > 'I''m sorry Sir, No Rewrite Allowed.'; > > Quite apart from any other reason, the "Sir" does seem a bit sexist - we > have no idea of the gender of the reader. Probably just 'sorry, no rewrite > allowed' would suffice. This seems pointless tinkering to me. Should I start introducing female pronouns in test error messages, to measure how much this will annoy my male conterparts? This is not a user visible message in any case. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Sun, Jan 04, 2015 at 12:20:09PM -0500, Andrew Dunstan wrote: > > I don't wish to seem humorless, but I think this should probably be changed: > > root/HEAD/pgsql/src/test/regress/sql/event_trigger.sql:248: RAISE EXCEPTION > 'I''m sorry Sir, No Rewrite Allowed.'; > > Quite apart from any other reason, the "Sir" does seem a bit sexist - we > have no idea of the gender of the reader. Probably just 'sorry, no rewrite > allowed' would suffice. We should change it to, "I'm sorry. I can't do that." http://en.wikipedia.org/wiki/2001:_A_Space_Odyssey_%28film%29 Cheers, David. -- David Fetter <david@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter@gmail.com Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
On Sun, Jan 4, 2015 at 8:09 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > Andrew Dunstan wrote: >> I don't wish to seem humorless, but I think this should probably be changed: >> >> root/HEAD/pgsql/src/test/regress/sql/event_trigger.sql:248: RAISE EXCEPTION >> 'I''m sorry Sir, No Rewrite Allowed.'; >> >> Quite apart from any other reason, the "Sir" does seem a bit sexist - we >> have no idea of the gender of the reader. Probably just 'sorry, no rewrite >> allowed' would suffice. > > This seems pointless tinkering to me. Should I start introducing female > pronouns in test error messages, to measure how much this will annoy my > male conterparts? This is not a user visible message in any case. I'm with Andrew. Aside from any question of sexism, which I do not discount, the capitalization is wrong. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company