Обсуждение: Commitfest: patches Ready for Committer

Поиск
Список
Период
Сортировка

Commitfest: patches Ready for Committer

От
Heikki Linnakangas
Дата:
In addition to the few patches left in Needs Review state, we have six 
patches marked as Ready for Committer.

Committers: Could you please pick a patch, and commit if appropriate? Or 
if there's a patch there that you think should *not* be committed, 
please speak up.

- Heikki



Re: Commitfest: patches Ready for Committer

От
Tom Lane
Дата:
Heikki Linnakangas <hlinnakangas@vmware.com> writes:
> Committers: Could you please pick a patch, and commit if appropriate? Or 
> if there's a patch there that you think should *not* be committed, 
> please speak up.

The "custom plan API" thing may be marked ready for committer, but that
doesn't mean it's committable, or even that there is any consensus about
whether we want it or what it should look like.

The levenshtein-distance thingy seems to still be a topic of debate
as well, both as to how we're going to refactor the code and as to
what the exact hinting rules ought to be.  If some committer wants
to take charge of it and resolve those issues, fine; but I don't want
to see it done by just blindly committing whatever the last submitted
version was.

I've not paid much of any attention to the other four.
        regards, tom lane



Re: Commitfest: patches Ready for Committer

От
Michael Paquier
Дата:
<div dir="ltr"><br /><div class="gmail_extra"><br /><div class="gmail_quote">On Mon, Oct 6, 2014 at 10:53 PM, Tom Lane
<spandir="ltr"><<a href="mailto:tgl@sss.pgh.pa.us" target="_blank">tgl@sss.pgh.pa.us</a>></span> wrote:<br
/><blockquoteclass="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The
levenshtein-distancethingy seems to still be a topic of debate<br /> as well, both as to how we're going to refactor
thecode and as to<br /> what the exact hinting rules ought to be.  If some committer wants<br /> to take charge of it
andresolve those issues, fine; but I don't want<br /> to see it done by just blindly committing whatever the last
submitted<br/> version was.<br /></blockquote></div><br />My 2c. I imagine that in this case the consensus is going to
befirst:<br /></div><div class="gmail_extra">- Move a minimum of the core functions of fuzzystrmatch and rename them
(str_distance?)<br/></div><div class="gmail_extra">- Do not dump fuzzystrmatch and have the levenshtein call those
functions<br/></div><div class="gmail_extra">In any case levenshtein code needs a careful refactoring and some
additionalthoughts first before the hint code is touched.<br /></div><div class="gmail_extra">Regards.<br /></div><div
class="gmail_extra">--<br />Michael<br /></div></div>