Commit 8b6010b8350a1756cd85595705971df81b5ffc07 eliminated the only usage of a variable called typeStruct in plpy_spi.c, but left the declaration and the code that sets a value for it. This is generating a warning when I build. I would have just pushed a fix, but I was concerned that it might have been left on purpose for some follow-on patch. Any objections to the attached, to silence the warning? -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Kevin Grittner <kgrittn@ymail.com> writes:
> Commit 8b6010b8350a1756cd85595705971df81b5ffc07 eliminated the only
> usage of a variable called typeStruct in plpy_spi.c, but left the
> declaration and the code that sets a value for it.� This is
> generating a warning when I build.� I would have just pushed a fix,
> but I was concerned that it might have been left on purpose for
> some follow-on patch. Any objections to the attached, to silence
> the warning?
Huh. Odd that I did not see such a warning here. No objection to
removing the dead variable.
regards, tom lane
Tom Lane <tgl@sss.pgh.pa.us> wrote: > Kevin Grittner <kgrittn@ymail.com> writes: >> typeStruct in plpy_spi.c > No objection to removing the dead variable. Done. -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Сайт использует файлы cookie для корректной работы и повышения удобства. Нажимая кнопку «Принять» или продолжая пользоваться сайтом, вы соглашаетесь на их использование в соответствии с Политикой в отношении обработки cookie ООО «ППГ», в том числе на передачу данных из файлов cookie сторонним статистическим и рекламным службам. Вы можете управлять настройками cookie через параметры вашего браузера