Обсуждение: Small doc patch for pg_replication_slots

Hello,

You can find attached a small patch to fix the pg_replication_slots
documentation. The slot_type and plugin are not in the appropriate
order, slot_name and plugin have a wrong type and xmin appears two times.

Regards
--
Thomas Reiss

On Tue, Apr 29, 2014 at 5:39 AM, Thomas Reiss <thomas.reiss@dalibo.com> wrote:
> You can find attached a small patch to fix the pg_replication_slots
> documentation. The slot_type and plugin are not in the appropriate
> order, slot_name and plugin have a wrong type and xmin appears two times.

Without the patch, the description of catalog_xmin is:
     <entry>The <literal>xmin</literal>, or oldest transaction ID, that this     slot forces to be retained in the
systemcatalogs. </entry>
 

With the patch it's:
     <entry>The oldest transaction that this slot needs the database to     retain.  <literal>VACUUM</literal> cannot
removecatalog tuples deleted     by any later transaction.
 

That's only one word different from the language for xmin, which
doesn't seem quite right.  Committed after fixing that.

...Robert

Le 01/05/2014 04:56, Robert Haas a écrit :
> On Tue, Apr 29, 2014 at 5:39 AM, Thomas Reiss <thomas.reiss@dalibo.com> wrote:
>> You can find attached a small patch to fix the pg_replication_slots
>> documentation. The slot_type and plugin are not in the appropriate
>> order, slot_name and plugin have a wrong type and xmin appears two times.
> 
> Without the patch, the description of catalog_xmin is:
> 
>       <entry>The <literal>xmin</literal>, or oldest transaction ID, that this
>       slot forces to be retained in the system catalogs. </entry>
> 
> With the patch it's:
> 
>       <entry>The oldest transaction that this slot needs the database to
>       retain.  <literal>VACUUM</literal> cannot remove catalog tuples deleted
>       by any later transaction.
> 
> That's only one word different from the language for xmin, which
> doesn't seem quite right.  Committed after fixing that.
> 
> ...Robert
> 

Thanks

-- 
Thomas Reiss
Consultant Dalibo
http://dalibo.com - http://dalibo.org