Обсуждение: commit fest 2013-11 final report

The commit fest is closed.  Final score:

Needs Review: 8, Ready for Committer: 13, Committed: 36, Returned with
Feedback: 42, Rejected: 9. Total: 108.


All patches that were in Waiting on Author or Needs Review state and
have received a decent review have been moved to Returned with Feedback
state.  Authors are encouraged to review the feedback and provide an
updated patch for the next commit fest.  Of course, you can also work
with the reviewers and committers to arrive at a resolution before then.

Committers should now try to get the Ready for Committer queue cleared.

That leaves 8 patches that haven't been reviewed.  If you take a look,
you can imagine why: They're the most complicated and obscure topics,
combined with reviewers who signed up but didn't get to do a review,
plus perhaps authors who were too busy to follow up aggressively.  I'll
leave those open in case someone still wants to take a look.  Authors
should move those patches forward to the next commit fest if they want.

Peter Eisentraut <peter_e@gmx.net> writes:
> Committers should now try to get the Ready for Committer queue cleared.

I'm still hacking on the WITHIN GROUP patch, and will look at the planner
indexes thing after that's done.

> That leaves 8 patches that haven't been reviewed.  If you take a look,
> you can imagine why: They're the most complicated and obscure topics,
> combined with reviewers who signed up but didn't get to do a review,
> plus perhaps authors who were too busy to follow up aggressively.  I'll
> leave those open in case someone still wants to take a look.  Authors
> should move those patches forward to the next commit fest if they want.

Perhaps we should just move all the Needs Review and RFC patches forward
to the next fest, so we don't forget about them?
        regards, tom lane

On 12/17/13, 10:19 AM, Tom Lane wrote:
> Perhaps we should just move all the Needs Review and RFC patches forward
> to the next fest, so we don't forget about them?

This was done the last few times, but it has caused some controversy.
One problem was that a number of patches arrived in this commit fest
without either the author or the reviewers knowing about it, which
caused the already somewhat stale patch to become completely abandoned.

I think what I'll do is send an email to each of the affected patch
threads describing the situation.  But I'd like someone involved in the
patch, either author or reviewer, to make the final call about moving
the patch forward.

On Tue, Dec 17, 2013 at 7:14 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On 12/17/13, 10:19 AM, Tom Lane wrote:
>> Perhaps we should just move all the Needs Review and RFC patches forward
>> to the next fest, so we don't forget about them?
>
> This was done the last few times, but it has caused some controversy.
> One problem was that a number of patches arrived in this commit fest
> without either the author or the reviewers knowing about it, which
> caused the already somewhat stale patch to become completely abandoned.
>
> I think what I'll do is send an email to each of the affected patch
> threads describing the situation.  But I'd like someone involved in the
> patch, either author or reviewer, to make the final call about moving
> the patch forward.

+1.  And thanks for your work on this CommitFest.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company