Обсуждение: Somebody broke \d on indexes

Поиск
Список
Период
Сортировка

Somebody broke \d on indexes

От
Tom Lane
Дата:
In HEAD:

regression=# \d tenk1_thous_tenthous
ERROR:  column i.indisidentity does not exist
LINE 4: i.indisidentity,       ^

This works fine in released versions.
        regards, tom lane



Re: Somebody broke \d on indexes

От
Andres Freund
Дата:
On 2013-11-14 09:52:11 -0500, Tom Lane wrote:
> In HEAD:
>
> regression=# \d tenk1_thous_tenthous
> ERROR:  column i.indisidentity does not exist
> LINE 4: i.indisidentity,
>         ^

That's me. At some point indisidentity was renamed to indisreplident.

Patch attached (also renaming a variable that didn't cause problems but
wasn't named consistently anymore).

Shouldn't we have at least one \d of an index in the regression tests
somewhere? Not that that excuses stupid mitakes, but it'd be helpful
nonetheless.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Вложения

Re: Somebody broke \d on indexes

От
Tom Lane
Дата:
Andres Freund <andres@2ndquadrant.com> writes:
> On 2013-11-14 09:52:11 -0500, Tom Lane wrote:
>> In HEAD:
>> 
>> regression=# \d tenk1_thous_tenthous
>> ERROR:  column i.indisidentity does not exist
>> LINE 4: i.indisidentity,
>> ^

> That's me. At some point indisidentity was renamed to indisreplident.

> Patch attached (also renaming a variable that didn't cause problems but
> wasn't named consistently anymore).

Ah, thanks, will commit.

> Shouldn't we have at least one \d of an index in the regression tests
> somewhere? Not that that excuses stupid mitakes, but it'd be helpful
> nonetheless.

Seems like a good idea, will add one of those too.
        regards, tom lane