[PATCH] warning: suggest braces around empty body in an 'else' statement

Поиск
Список
Период
Сортировка
Искать

[PATCH] warning: suggest braces around empty body in an 'else' statement

От:
Andres Freund <andres@2ndquadrant.com>
Дата:
Hi,

Compiling postgres I currently get the following warning when compiling
without LOCK_DEBUG:
/home/andres/src/postgresql/src/backend/storage/lmgr/lock.c:944:52:
warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
     PROCLOCK_PRINT("LockAcquire: NOWAIT", proclock);

It'd be easy to just disable the warning with -Wno-empty-body, but I actually like
the warning.

It's easy to fix by defining PROCLOCK_PRINT to (void)0 instead of
defining it empty when LOCK_DEBUG is enabled.

Greetings,

Andres Freund

-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Re: [PATCH] warning: suggest braces around empty body in an 'else' statement

От:
Tom Lane <tgl@sss.pgh.pa.us>
Дата:
FAQ