Обсуждение: Re: [COMMITTERS] pgsql: Implement genuine serializable isolation level.

Поиск
Список
Период
Сортировка

Re: [COMMITTERS] pgsql: Implement genuine serializable isolation level.

От
Robert Haas
Дата:
On Mon, Feb 7, 2011 at 5:11 PM, Heikki Linnakangas
<heikki.linnakangas@iki.fi> wrote:
> Implement genuine serializable isolation level.

With gcc version 4.2.1 (Apple Inc. build 5664):

predicate.c: In function ‘CheckTargetForConflictsIn’:
predicate.c:3674: warning: ‘nexttargettag.locktag_field5’ may be used
uninitialized in this function
predicate.c:3674: warning: ‘nexttargettag.locktag_field4’ may be used
uninitialized in this function
predicate.c:3674: warning: ‘nexttargettag.locktag_field3’ may be used
uninitialized in this function
predicate.c:3674: warning: ‘nexttargettag.locktag_field2’ may be used
uninitialized in this function
predicate.c:3674: warning: ‘nexttargettag.locktag_field1’ may be used
uninitialized in this function

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [COMMITTERS] pgsql: Implement genuine serializable isolation level.

От
Heikki Linnakangas
Дата:
On 08.02.2011 05:03, Robert Haas wrote:
> On Mon, Feb 7, 2011 at 5:11 PM, Heikki Linnakangas
> <heikki.linnakangas@iki.fi>  wrote:
>> Implement genuine serializable isolation level.
>
> With gcc version 4.2.1 (Apple Inc. build 5664):
>
> predicate.c: In function ‘CheckTargetForConflictsIn’:
> predicate.c:3674: warning: ‘nexttargettag.locktag_field5’ may be used
> uninitialized in this function
> predicate.c:3674: warning: ‘nexttargettag.locktag_field4’ may be used
> uninitialized in this function
> predicate.c:3674: warning: ‘nexttargettag.locktag_field3’ may be used
> uninitialized in this function
> predicate.c:3674: warning: ‘nexttargettag.locktag_field2’ may be used
> uninitialized in this function
> predicate.c:3674: warning: ‘nexttargettag.locktag_field1’ may be used
> uninitialized in this function

Thanks, fixed. I didn't get that warning on gcc 4.4.5, but apparently 
older gcc versions are more picky on that.

Also fixed a copy-pasto in my addition of pg_serial in the docs, pointed 
out by Kevin off-list.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com