Обсуждение: GetOldestWALSendPointer() in header

Hi,

GetOldestWALSendPointer() is commented out in the source code
with NOT_USED block, but is still declared in the header file.
Should we remove the function prototype from walsender.h ?

[walsender.h]   extern XLogRecPtr GetOldestWALSendPointer(void);

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center

Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> writes:
> GetOldestWALSendPointer() is commented out in the source code
> with NOT_USED block, but is still declared in the header file.
> Should we remove the function prototype from walsender.h ?

Yes, that's our usual convention.
        regards, tom lane