Обсуждение: Mismatch in libpqwalreceiver

Поиск
Список
Период
Сортировка

Mismatch in libpqwalreceiver

От
Hitoshi Harada
Дата:
There's a mismatch in HEAD between README and the actual definition in
replication/libpqwalreceiver.

In README,

bool walrcv_receive(int timeout, XLogRecPtr *recptr, char **buffer, int *len)

but in walreceiver.h,

typedef bool (*walrcv_receive_type) (int timeout, unsigned char *type,                                             char
**buffer,int *len);
 


It seems this commit forgot README fix.

http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.5&r2=1.6


Regards,


-- 
Hitoshi Harada

Re: Mismatch in libpqwalreceiver

От
Fujii Masao
Дата:
On Wed, Mar 24, 2010 at 1:49 AM, Hitoshi Harada <umi.tanuki@gmail.com> wrote:
> There's a mismatch in HEAD between README and the actual definition in
> replication/libpqwalreceiver.
>
> In README,
>
> bool walrcv_receive(int timeout, XLogRecPtr *recptr, char **buffer, int *len)
>
> but in walreceiver.h,
>
> typedef bool (*walrcv_receive_type) (int timeout, unsigned char *type,
>                                                                                                 char **buffer, int
*len);
>
>
> It seems this commit forgot README fix.
>
> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.5&r2=1.6

Thanks for the report! That is my mistake. Here is the patch.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Вложения

Re: Mismatch in libpqwalreceiver

От
Heikki Linnakangas
Дата:
Fujii Masao wrote:
> On Wed, Mar 24, 2010 at 1:49 AM, Hitoshi Harada <umi.tanuki@gmail.com> wrote:
>> It seems this commit forgot README fix.
>>
>> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.5&r2=1.6
> 
> Thanks for the report!

Yep, thanks. Applied, and I also added description of the returned values.

--  Heikki Linnakangas EnterpriseDB   http://www.enterprisedb.com