Обсуждение: missing $PostgreSQL:$

Поиск
Список
Период
Сортировка

missing $PostgreSQL:$

От
Andrew Dunstan
Дата:
I have just noticed that pg_standby.c is missing a $PostgreSQL:$ line.

Do we have a script that goes looking for such files? Do we need one?

cheers

andrew

Re: missing $PostgreSQL:$

От
Bruce Momjian
Дата:
Andrew Dunstan wrote:
> 
> I have just noticed that pg_standby.c is missing a $PostgreSQL:$ line.
> 
> Do we have a script that goes looking for such files? Do we need one?

I don't think we have one but it would be nice to have.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +

Re: missing $PostgreSQL:$

От
Tom Lane
Дата:
Bruce Momjian <bruce@momjian.us> writes:
> Andrew Dunstan wrote:
>> Do we have a script that goes looking for such files? Do we need one?

> I don't think we have one but it would be nice to have.

Only if it's bright enough to know about files that we intentionally
don't put $PostgreSQL$ into ...
        regards, tom lane

Re: missing $PostgreSQL:$

От
Andrew Dunstan
Дата:

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
>   
>> Andrew Dunstan wrote:
>>     
>>> Do we have a script that goes looking for such files? Do we need one?
>>>       
>
>   
>> I don't think we have one but it would be nice to have.
>>     
>
> Only if it's bright enough to know about files that we intentionally
> don't put $PostgreSQL$ into ...
>   

Here's a very early cut. Tell me what extra intelligence you want and 
I'll work something up. It certainly looks to me like many of these 
should have markers. There are probably some other files we should be 
checking, too.

cheers

andrew

[andrew@constanza pgsql.head]$ find . \( -name '*.[chly]' -o -name 
'*akefile' -o -name '*.sgml' \) \( -exec grep -q '\$PostgreSQL' {} \; -o 
-print \)
./Makefile
./src/tools/fsync/test_fsync.c
./src/tools/entab/Makefile
./src/test/locale/de_DE.ISO8859-1/Makefile
./src/test/locale/gr_GR.ISO8859-7/Makefile
./src/test/locale/koi8-r/Makefile
./src/test/locale/koi8-to-win1251/Makefile
./src/test/locale/test-ctype.c
./src/test/regress/Makefile
./src/test/examples/testlibpq3.c
./src/test/examples/Makefile
./src/test/examples/testlibpq.c
./src/test/examples/testlibpq4.c
./src/test/examples/testlibpq2.c
./src/include/utils/cash.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_finnish.h
./src/include/snowball/libstemmer/stem_UTF_8_german.h
./src/include/snowball/libstemmer/stem_KOI8_R_russian.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_portuguese.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_norwegian.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_german.h
./src/include/snowball/libstemmer/api.h
./src/include/snowball/libstemmer/stem_UTF_8_dutch.h
./src/include/snowball/libstemmer/stem_UTF_8_french.h
./src/include/snowball/libstemmer/stem_UTF_8_norwegian.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_dutch.h
./src/include/snowball/libstemmer/stem_UTF_8_italian.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_french.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_swedish.h
./src/include/snowball/libstemmer/stem_UTF_8_turkish.h
./src/include/snowball/libstemmer/stem_UTF_8_romanian.h
./src/include/snowball/libstemmer/stem_UTF_8_portuguese.h
./src/include/snowball/libstemmer/stem_UTF_8_finnish.h
./src/include/snowball/libstemmer/stem_UTF_8_english.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_english.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_spanish.h
./src/include/snowball/libstemmer/stem_ISO_8859_2_romanian.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_italian.h
./src/include/snowball/libstemmer/stem_UTF_8_hungarian.h
./src/include/snowball/libstemmer/header.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_hungarian.h
./src/include/snowball/libstemmer/stem_UTF_8_danish.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_danish.h
./src/include/snowball/libstemmer/stem_UTF_8_swedish.h
./src/include/snowball/libstemmer/stem_UTF_8_porter.h
./src/include/snowball/libstemmer/stem_UTF_8_spanish.h
./src/include/snowball/libstemmer/stem_ISO_8859_1_porter.h
./src/include/snowball/libstemmer/stem_UTF_8_russian.h
./src/include/port/sunos4.h
./src/include/port/aix.h
./src/include/port/sco.h
./src/include/port/univel.h
./src/include/port/ultrix4.h
./src/include/port/win32/pwd.h
./src/include/port/win32/sys/wait.h
./src/include/port/bsdi.h
./src/include/port/unixware.h
./src/include/commands/proclang.h
./src/include/commands/comment.h
./src/tutorial/complex.c
./src/port/pthread-win32.h
./src/port/strtol.c
./src/port/rand.c
./src/port/strlcat.c
./src/port/strtoul.c
./src/bin/pgevent/Makefile
./src/interfaces/libpq/win32.h
./src/interfaces/libpq/win32.c
./src/interfaces/ecpg/pgtypeslib/timestamp.c
./src/interfaces/ecpg/test/thread/Makefile
./src/interfaces/ecpg/test/pgtypeslib/Makefile
./src/interfaces/ecpg/test/sql/Makefile
./src/interfaces/ecpg/test/expected/preproc-comment.c
./src/interfaces/ecpg/test/expected/preproc-autoprep.c
./src/interfaces/ecpg/test/expected/sql-array.c
./src/interfaces/ecpg/test/expected/compat_informix-rfmtdate.c
./src/interfaces/ecpg/test/expected/sql-indicators.c
./src/interfaces/ecpg/test/expected/preproc-variable.c
./src/interfaces/ecpg/test/expected/sql-oldexec.c
./src/interfaces/ecpg/test/expected/connect-test4.c
./src/interfaces/ecpg/test/expected/compat_informix-charfuncs.c
./src/interfaces/ecpg/test/expected/connect-test3.c
./src/interfaces/ecpg/test/expected/sql-dyntest.c
./src/interfaces/ecpg/test/expected/sql-quote.c
./src/interfaces/ecpg/test/expected/pgtypeslib-dt_test.c
./src/interfaces/ecpg/test/expected/pgtypeslib-num_test2.c
./src/interfaces/ecpg/test/expected/sql-code100.c
./src/interfaces/ecpg/test/expected/sql-parser.c
./src/interfaces/ecpg/test/expected/compat_informix-test_informix.c
./src/interfaces/ecpg/test/expected/preproc-type.c
./src/interfaces/ecpg/test/expected/compat_informix-test_informix2.c
./src/interfaces/ecpg/test/expected/preproc-init.c
./src/interfaces/ecpg/test/expected/Makefile
./src/interfaces/ecpg/test/expected/thread-alloc.c
./src/interfaces/ecpg/test/expected/sql-dynalloc.c
./src/interfaces/ecpg/test/expected/preproc-array_of_struct.c
./src/interfaces/ecpg/test/expected/sql-func.c
./src/interfaces/ecpg/test/expected/sql-define.c
./src/interfaces/ecpg/test/expected/thread-thread_implicit.c
./src/interfaces/ecpg/test/expected/sql-insupd.c
./src/interfaces/ecpg/test/expected/sql-desc.c
./src/interfaces/ecpg/test/expected/sql-binary.c
./src/interfaces/ecpg/test/expected/thread-descriptor.c
./src/interfaces/ecpg/test/expected/preproc-define.c
./src/interfaces/ecpg/test/expected/pgtypeslib-num_test.c
./src/interfaces/ecpg/test/expected/compat_informix-rnull.c
./src/interfaces/ecpg/test/expected/sql-dynalloc2.c
./src/interfaces/ecpg/test/expected/compat_informix-rfmtlong.c
./src/interfaces/ecpg/test/expected/sql-fetch.c
./src/interfaces/ecpg/test/expected/thread-thread.c
./src/interfaces/ecpg/test/expected/compat_informix-dec_test.c
./src/interfaces/ecpg/test/expected/sql-show.c
./src/interfaces/ecpg/test/expected/connect-test2.c
./src/interfaces/ecpg/test/expected/pgtypeslib-dt_test2.c
./src/interfaces/ecpg/test/expected/preproc-whenever.c
./src/interfaces/ecpg/test/expected/connect-test5.c
./src/interfaces/ecpg/test/expected/sql-copystdout.c
./src/interfaces/ecpg/test/expected/sql-execute.c
./src/interfaces/ecpg/test/expected/thread-prep.c
./src/interfaces/ecpg/test/preproc/Makefile
./src/interfaces/ecpg/test/connect/Makefile
./src/interfaces/ecpg/test/compat_informix/Makefile
./src/interfaces/ecpg/test/regression.h
./src/interfaces/ecpg/preproc/type.h
./src/interfaces/ecpg/Makefile
./src/interfaces/ecpg/include/sql3types.h
./src/interfaces/ecpg/include/sqlca.h
./src/interfaces/ecpg/include/sqlda.h
./src/interfaces/ecpg/include/Makefile
./src/interfaces/ecpg/include/sqltypes.h
./src/pl/plperl/spi_internal.c
./src/pl/plperl/ppport.h
./src/backend/utils/mb/wstrcmp.c
./src/backend/utils/mb/wstrncmp.c
./src/backend/snowball/libstemmer/stem_UTF_8_french.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_english.c
./src/backend/snowball/libstemmer/stem_UTF_8_turkish.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_norwegian.c
./src/backend/snowball/libstemmer/stem_UTF_8_hungarian.c
./src/backend/snowball/libstemmer/stem_UTF_8_porter.c
./src/backend/snowball/libstemmer/stem_UTF_8_russian.c
./src/backend/snowball/libstemmer/stem_UTF_8_italian.c
./src/backend/snowball/libstemmer/stem_UTF_8_portuguese.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_italian.c
./src/backend/snowball/libstemmer/stem_UTF_8_english.c
./src/backend/snowball/libstemmer/stem_UTF_8_norwegian.c
./src/backend/snowball/libstemmer/stem_KOI8_R_russian.c
./src/backend/snowball/libstemmer/stem_ISO_8859_2_romanian.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_portuguese.c
./src/backend/snowball/libstemmer/api.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_finnish.c
./src/backend/snowball/libstemmer/stem_UTF_8_romanian.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_porter.c
./src/backend/snowball/libstemmer/stem_UTF_8_dutch.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_danish.c
./src/backend/snowball/libstemmer/stem_UTF_8_german.c
./src/backend/snowball/libstemmer/stem_UTF_8_danish.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_dutch.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_french.c
./src/backend/snowball/libstemmer/stem_UTF_8_spanish.c
./src/backend/snowball/libstemmer/stem_UTF_8_swedish.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_german.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_swedish.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_hungarian.c
./src/backend/snowball/libstemmer/stem_UTF_8_finnish.c
./src/backend/snowball/libstemmer/utilities.c
./src/backend/snowball/libstemmer/stem_ISO_8859_1_spanish.c
./src/backend/port/dynloader/aix.c
./src/backend/port/dynloader/univel.c
./src/backend/port/dynloader/win32.h
./src/backend/port/dynloader/univel.h
./src/backend/port/dynloader/solaris.c
./src/backend/port/dynloader/svr4.c
./src/backend/port/dynloader/unixware.c
./src/backend/port/dynloader/sunos4.c
./src/backend/port/dynloader/sco.c
./src/backend/port/dynloader/unixware.h
./src/backend/port/darwin/system.c
./src/backend/port/nextstep/port.c
./contrib/tablefunc/tablefunc.h
./contrib/tablefunc/tablefunc.c
./contrib/pg_trgm/trgm_op.c
./contrib/pg_trgm/trgm_gin.c
./contrib/pg_trgm/trgm.h
./contrib/pg_trgm/trgm_gist.c
./contrib/pgstattuple/pgstatindex.c
./contrib/btree_gist/btree_int2.c
./contrib/btree_gist/btree_time.c
./contrib/btree_gist/btree_date.c
./contrib/btree_gist/btree_int8.c
./contrib/btree_gist/btree_utils_var.h
./contrib/btree_gist/btree_cash.c
./contrib/btree_gist/btree_bytea.c
./contrib/btree_gist/btree_inet.c
./contrib/btree_gist/btree_gist.h
./contrib/btree_gist/btree_utils_var.c
./contrib/btree_gist/btree_bit.c
./contrib/btree_gist/btree_int4.c
./contrib/btree_gist/btree_numeric.c
./contrib/btree_gist/btree_gist.c
./contrib/btree_gist/btree_oid.c
./contrib/btree_gist/btree_utils_num.c
./contrib/btree_gist/btree_utils_num.h
./contrib/btree_gist/btree_float8.c
./contrib/btree_gist/btree_macaddr.c
./contrib/btree_gist/btree_ts.c
./contrib/btree_gist/btree_interval.c
./contrib/btree_gist/btree_text.c
./contrib/btree_gist/btree_float4.c
./contrib/ltree/_ltree_op.c
./contrib/ltree/_ltree_gist.c
./contrib/intarray/_int_bool.c
./contrib/intarray/_int.h
./contrib/intarray/_intbig_gist.c
./contrib/intarray/_int_gist.c
./contrib/intarray/_int_tool.c
./contrib/intarray/_int_op.c
./contrib/intarray/_int_gin.c
./contrib/pgcrypto/rijndael.h
./contrib/spi/autoinc.c
./contrib/spi/refint.c
./contrib/spi/timetravel.c
./contrib/xml2/xslt_proc.c
./contrib/xml2/xpath.c
./contrib/pg_standby/pg_standby.c
./contrib/pageinspect/btreefuncs.c
./contrib/seg/segscan.l
./contrib/seg/seg.c
./contrib/seg/segparse.y
./contrib/seg/segdata.h
./contrib/hstore/hstore.h
./contrib/hstore/hstore_io.c
./contrib/hstore/hstore_gist.c
./contrib/hstore/hstore_gin.c
./contrib/hstore/crc32.c
./contrib/hstore/hstore_op.c
./contrib/hstore/crc32.h

Re: missing $PostgreSQL:$

От
Alvaro Herrera
Дата:
Andrew Dunstan wrote:

> Here's a very early cut. Tell me what extra intelligence you want and  
> I'll work something up. It certainly looks to me like many of these  
> should have markers. There are probably some other files we should be  
> checking, too.

I suggest adding -name "*.mk" and excluding generated files, like those
in libstemmer and ecpg/test/expected.  And plperl/ppport.h

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Re: missing $PostgreSQL:$

От
Andrew Dunstan
Дата:

Alvaro Herrera wrote:
> Andrew Dunstan wrote:
>
>   
>> Here's a very early cut. Tell me what extra intelligence you want and  
>> I'll work something up. It certainly looks to me like many of these  
>> should have markers. There are probably some other files we should be  
>> checking, too.
>>     
>
> I suggest adding -name "*.mk" and excluding generated files, like those
> in libstemmer and ecpg/test/expected.  And plperl/ppport.h
>
>   

second pass. There are 130 files in this list. Offhand I'd say the vast 
majority should have markers.

cheers

andrew

[andrew@constanza pgsql.head]$ find . \( \( -name 'libstemmer' -o -name 
'expected' -o -name 'ppport.h' \) -prune \) -o  \( -name '*.[chly]' -o 
-name '*akefile'  -o -name '*.mk'  -o -name '*.sgml' -o -name '*.p[lm]' 
\) \( -exec grep -q '\$PostgreSQL' {} \; -o -print \)
./Makefile
./src/tools/fsync/test_fsync.c
./src/tools/entab/Makefile
./src/tools/msvc/config.pl
./src/test/performance/runtests.pl
./src/test/locale/de_DE.ISO8859-1/Makefile
./src/test/locale/gr_GR.ISO8859-7/Makefile
./src/test/locale/koi8-r/Makefile
./src/test/locale/sort-test.pl
./src/test/locale/koi8-to-win1251/Makefile
./src/test/locale/test-ctype.c
./src/test/regress/Makefile
./src/test/examples/testlibpq3.c
./src/test/examples/Makefile
./src/test/examples/testlibpq.c
./src/test/examples/testlibpq4.c
./src/test/examples/testlibpq2.c
./src/include/utils/cash.h
./src/include/port/sunos4.h
./src/include/port/aix.h
./src/include/port/sco.h
./src/include/port/univel.h
./src/include/port/ultrix4.h
./src/include/port/win32/pwd.h
./src/include/port/win32/sys/wait.h
./src/include/port/bsdi.h
./src/include/port/unixware.h
./src/include/commands/proclang.h
./src/include/commands/comment.h
./src/tutorial/complex.c
./src/port/pthread-win32.h
./src/port/strtol.c
./src/port/rand.c
./src/port/strlcat.c
./src/port/strtoul.c
./src/bin/pgevent/Makefile
./src/interfaces/libpq/win32.h
./src/interfaces/libpq/win32.c
./src/interfaces/ecpg/pgtypeslib/timestamp.c
./src/interfaces/ecpg/test/thread/Makefile
./src/interfaces/ecpg/test/pgtypeslib/Makefile
./src/interfaces/ecpg/test/sql/Makefile
./src/interfaces/ecpg/test/preproc/Makefile
./src/interfaces/ecpg/test/connect/Makefile
./src/interfaces/ecpg/test/compat_informix/Makefile
./src/interfaces/ecpg/test/regression.h
./src/interfaces/ecpg/preproc/type.h
./src/interfaces/ecpg/Makefile
./src/interfaces/ecpg/include/sql3types.h
./src/interfaces/ecpg/include/sqlca.h
./src/interfaces/ecpg/include/sqlda.h
./src/interfaces/ecpg/include/Makefile
./src/interfaces/ecpg/include/sqltypes.h
./src/pl/plperl/spi_internal.c
./src/backend/utils/mb/wstrcmp.c
./src/backend/utils/mb/wstrncmp.c
./src/backend/utils/mb/conversion_procs/proc.mk
./src/backend/port/dynloader/aix.c
./src/backend/port/dynloader/univel.c
./src/backend/port/dynloader/win32.h
./src/backend/port/dynloader/univel.h
./src/backend/port/dynloader/solaris.c
./src/backend/port/dynloader/svr4.c
./src/backend/port/dynloader/unixware.c
./src/backend/port/dynloader/sunos4.c
./src/backend/port/dynloader/sco.c
./src/backend/port/dynloader/unixware.h
./src/backend/port/darwin/system.c
./src/backend/port/nextstep/port.c
./contrib/tablefunc/tablefunc.h
./contrib/tablefunc/tablefunc.c
./contrib/pg_trgm/trgm_op.c
./contrib/pg_trgm/trgm_gin.c
./contrib/pg_trgm/trgm.h
./contrib/pg_trgm/trgm_gist.c
./contrib/pgstattuple/pgstatindex.c
./contrib/btree_gist/btree_int2.c
./contrib/btree_gist/btree_time.c
./contrib/btree_gist/btree_date.c
./contrib/btree_gist/btree_int8.c
./contrib/btree_gist/btree_utils_var.h
./contrib/btree_gist/btree_cash.c
./contrib/btree_gist/btree_bytea.c
./contrib/btree_gist/btree_inet.c
./contrib/btree_gist/btree_gist.h
./contrib/btree_gist/btree_utils_var.c
./contrib/btree_gist/btree_bit.c
./contrib/btree_gist/btree_int4.c
./contrib/btree_gist/btree_numeric.c
./contrib/btree_gist/btree_gist.c
./contrib/btree_gist/btree_oid.c
./contrib/btree_gist/btree_utils_num.c
./contrib/btree_gist/btree_utils_num.h
./contrib/btree_gist/btree_float8.c
./contrib/btree_gist/btree_macaddr.c
./contrib/btree_gist/btree_ts.c
./contrib/btree_gist/btree_interval.c
./contrib/btree_gist/btree_text.c
./contrib/btree_gist/btree_float4.c
./contrib/ltree/_ltree_op.c
./contrib/ltree/_ltree_gist.c
./contrib/intarray/_int_bool.c
./contrib/intarray/_int.h
./contrib/intarray/_intbig_gist.c
./contrib/intarray/bench/bench.pl
./contrib/intarray/_int_gist.c
./contrib/intarray/_int_tool.c
./contrib/intarray/_int_op.c
./contrib/intarray/_int_gin.c
./contrib/pgcrypto/rijndael.h
./contrib/spi/autoinc.c
./contrib/spi/refint.c
./contrib/spi/timetravel.c
./contrib/xml2/xslt_proc.c
./contrib/xml2/xpath.c
./contrib/pg_standby/pg_standby.c
./contrib/pageinspect/btreefuncs.c
./contrib/seg/seg-validate.pl
./contrib/seg/sort-segments.pl
./contrib/seg/segscan.l
./contrib/seg/seg.c
./contrib/seg/segparse.y
./contrib/seg/segdata.h
./contrib/hstore/hstore.h
./contrib/hstore/hstore_io.c
./contrib/hstore/hstore_gist.c
./contrib/hstore/hstore_gin.c
./contrib/hstore/crc32.c
./contrib/hstore/hstore_op.c
./contrib/hstore/crc32.h

Re: missing $PostgreSQL:$

От
Tom Lane
Дата:
Andrew Dunstan <andrew@dunslane.net> writes:
> second pass. There are 130 files in this list. Offhand I'd say the vast 
> majority should have markers.

Yeah, that list looks reasonably sane.  The main thing I was worried
about was not plastering PostgreSQL markers on files that are simply
imported from an upstream source, like the zic database and the
libstemmer files.
        regards, tom lane

Re: missing $PostgreSQL:$

От
Andrew Dunstan
Дата:

Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>   
>> second pass. There are 130 files in this list. Offhand I'd say the vast 
>> majority should have markers.
>>     
>
> Yeah, that list looks reasonably sane.  The main thing I was worried
> about was not plastering PostgreSQL markers on files that are simply
> imported from an upstream source, like the zic database and the
> libstemmer files.
>
>
>   

The following files have markers from upstream systems. I'm not sure 
that means we don't want to add $PostgreSQL$ markers, though. Thoughts?

./src/port/strlcat.c:/* $OpenBSD: strlcat.c,v 1.13 2005/08/08 08:05:37 
espie Exp $      */
./src/backend/port/darwin/system.c: * $FreeBSD: 
src/lib/libc/stdlib/system.c,v 1.6 2000/03/16 02:14:41 jasone Exp $
./contrib/pgcrypto/rijndael.h:/*        $OpenBSD: rijndael.h,v 1.3 
2001/05/09 23:01:32 markus Exp $ */

cheers

andrew

Re: missing $PostgreSQL:$

От
Tom Lane
Дата:
Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> Yeah, that list looks reasonably sane.  The main thing I was worried
>> about was not plastering PostgreSQL markers on files that are simply
>> imported from an upstream source, like the zic database and the
>> libstemmer files.

> The following files have markers from upstream systems. I'm not sure 
> that means we don't want to add $PostgreSQL$ markers, though. Thoughts?

> ./src/port/strlcat.c:/* $OpenBSD: strlcat.c,v 1.13 2005/08/08 08:05:37 
> espie Exp $      */
> ./src/backend/port/darwin/system.c: * $FreeBSD: 
> src/lib/libc/stdlib/system.c,v 1.6 2000/03/16 02:14:41 jasone Exp $
> ./contrib/pgcrypto/rijndael.h:/*        $OpenBSD: rijndael.h,v 1.3 
> 2001/05/09 23:01:32 markus Exp $ */

I don't have an objection to putting markers on these files, because
as far as I know we're maintaining them as if they were our own source.
The zic and libstemmer files are different because they are not intended
to be maintained in-house --- we're just gonna download and mass-update
from time to time.
        regards, tom lane

Re: missing $PostgreSQL:$

От
"Marko Kreen"
Дата:
On 5/17/08, Andrew Dunstan <andrew@dunslane.net> wrote:
>  Tom Lane wrote:
> > Andrew Dunstan <andrew@dunslane.net> writes:
> > > second pass. There are 130 files in this list. Offhand I'd say the vast
> majority should have markers.
> >
> > Yeah, that list looks reasonably sane.  The main thing I was worried
> > about was not plastering PostgreSQL markers on files that are simply
> > imported from an upstream source, like the zic database and the
> > libstemmer files.
>
>  The following files have markers from upstream systems. I'm not sure that
> means we don't want to add $PostgreSQL$ markers, though. Thoughts?
>
>  ./src/port/strlcat.c:/* $OpenBSD: strlcat.c,v 1.13 2005/08/08 08:05:37
> espie Exp $      */
>  ./src/backend/port/darwin/system.c: * $FreeBSD:
> src/lib/libc/stdlib/system.c,v 1.6 2000/03/16 02:14:41 jasone Exp $
>  ./contrib/pgcrypto/rijndael.h:/*        $OpenBSD:
> rijndael.h,v 1.3 2001/05/09 23:01:32 markus Exp $ */

You can add, but please keep upstream marker.

-- 
marko