Обсуждение: Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Andrew Dunstan wrote:
>> Log Message:
>> -----------
>> Improve logic for finding object files on OBJS lines in contrib Makefiles. If this unbreaks buildfarm mastodon,
applyeverywhere.
 

> I start to wonder why don't we just implement our own make in Perl ...

http://search.cpan.org/~mhosken/Font-Fret-1.202/pmake.bat
        regards, tom lane

Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
>   
>> Andrew Dunstan wrote:
>>     
>>> Log Message:
>>> -----------
>>> Improve logic for finding object files on OBJS lines in contrib Makefiles. If this unbreaks buildfarm mastodon,
applyeverywhere.
 
>>>       
>
>   
>> I start to wonder why don't we just implement our own make in Perl ...
>>     
>
> http://search.cpan.org/~mhosken/Font-Fret-1.202/pmake.bat
>
>             
>   

The point is not to emulate make. Gmake for windows already exists, 
anyway. The point is that building for MSVC is so very different from 
the way you build everywhere else. Our current tools build MSVC project 
files and then drive the build from there. Having a make equivalent 
won't help us much.

cheers

andrew

Andrew Dunstan wrote:
> 
> 
> Tom Lane wrote:
> > Alvaro Herrera <alvherre@commandprompt.com> writes:
> >   
> >> Andrew Dunstan wrote:
> >>     
> >>> Log Message:
> >>> -----------
> >>> Improve logic for finding object files on OBJS lines in contrib
> >>> Makefiles. If this unbreaks buildfarm mastodon, apply everywhere. 
> >
> >   
> >> I start to wonder why don't we just implement our own make in
> >> Perl ... 
> >
> > http://search.cpan.org/~mhosken/Font-Fret-1.202/pmake.bat
> >
> >             
> >   
> 
> The point is not to emulate make. Gmake for windows already exists, 
> anyway. The point is that building for MSVC is so very different from 
> the way you build everywhere else. Our current tools build MSVC
> project files and then drive the build from there. Having a make
> equivalent won't help us much.

Right. The easiest way if you're building something for scratch is to
use a system that natively supports msvc, such as cmake. But that means
a complete replacement of the build system, which is certainly
"somewhat invasive".. ;-)

//Magnus

Andrew Dunstan wrote:
>
>
> Tom Lane wrote:
>> Alvaro Herrera <alvherre@commandprompt.com> writes:
>>   
>>> Andrew Dunstan wrote:
>>>     
>>>> Log Message:
>>>> -----------
>>>> Improve logic for finding object files on OBJS lines in contrib Makefiles. If this unbreaks buildfarm mastodon,
applyeverywhere.
 
>>>>       
>>
>>   
>>> I start to wonder why don't we just implement our own make in Perl ...
>>>     
>>
>> http://search.cpan.org/~mhosken/Font-Fret-1.202/pmake.bat
>
> The point is not to emulate make. Gmake for windows already exists,  
> anyway. The point is that building for MSVC is so very different from  
> the way you build everywhere else. Our current tools build MSVC project  
> files and then drive the build from there. Having a make equivalent  
> won't help us much.

What I was actually thinking was using this make reimplementation to
generate the MSVC project files, instead of parsing the makefiles to do
the same.  So we would need extra Makefiles with infrastructure to do
that, but we would get away from the text parsing business.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Am Freitag, 9. Mai 2008 schrieb Tom Lane:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > Andrew Dunstan wrote:
> >> Log Message:
> >> -----------
> >> Improve logic for finding object files on OBJS lines in contrib
> >> Makefiles. If this unbreaks buildfarm mastodon, apply everywhere.
> >
> > I start to wonder why don't we just implement our own make in Perl ...
>
> http://search.cpan.org/~mhosken/Font-Fret-1.202/pmake.bat

Interesting.

But surely putting a GNU make binary at some download location would be even 
easier.

Am Freitag, 9. Mai 2008 schrieb Magnus Hagander:
> Right. The easiest way if you're building something for scratch is to
> use a system that natively supports msvc, such as cmake. But that means
> a complete replacement of the build system, which is certainly
> "somewhat invasive".. ;-)

For the record, I'd be interested in trying out cmake.

Peter Eisentraut wrote:
> Am Freitag, 9. Mai 2008 schrieb Tom Lane:
>   
>> Alvaro Herrera <alvherre@commandprompt.com> writes:
>>     
>>> Andrew Dunstan wrote:
>>>       
>>>> Log Message:
>>>> -----------
>>>> Improve logic for finding object files on OBJS lines in contrib
>>>> Makefiles. If this unbreaks buildfarm mastodon, apply everywhere.
>>>>         
>>> I start to wonder why don't we just implement our own make in Perl ...
>>>       
>> http://search.cpan.org/~mhosken/Font-Fret-1.202/pmake.bat
>>     
>
> Interesting.
>
> But surely putting a GNU make binary at some download location would be even 
> easier.
>
>   

As I have already pointed out elsewhere:

"The point is not to emulate make. Gmake for windows already exists, 
anyway. The point is that building for MSVC is so very different from 
the way you build everywhere else. Our current tools build MSVC project 
files and then drive the build from there. Having a make equivalent 
won't help us much. "

cheers

andrew

Peter Eisentraut wrote:
> Am Freitag, 9. Mai 2008 schrieb Magnus Hagander:
> > Right. The easiest way if you're building something for scratch is to
> > use a system that natively supports msvc, such as cmake. But that means
> > a complete replacement of the build system, which is certainly
> > "somewhat invasive".. ;-)
> 
> For the record, I'd be interested in trying out cmake.

Then let's talk about it at the developer's meeting.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Alvaro Herrera wrote:
> Peter Eisentraut wrote:
> > Am Freitag, 9. Mai 2008 schrieb Magnus Hagander:
> > > Right. The easiest way if you're building something for scratch
> > > is to use a system that natively supports msvc, such as cmake.
> > > But that means a complete replacement of the build system, which
> > > is certainly "somewhat invasive".. ;-)
> > 
> > For the record, I'd be interested in trying out cmake.
> 
> Then let's talk about it at the developer's meeting.

+1. If there is time, let's please add that to the schedule.

//Magnus

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Peter Eisentraut wrote:
>> For the record, I'd be interested in trying out cmake.

> Then let's talk about it at the developer's meeting.

Is there anything that will be useful to say unless someone's done
some experiments to look at?
        regards, tom lane