Обсуждение: Re: [COMMITTERS] pgsql: Remove some of the most blatant brain-fade in the recent guc

Поиск
Список
Период
Сортировка

Re: [COMMITTERS] pgsql: Remove some of the most blatant brain-fade in the recent guc

От
Bruce Momjian
Дата:
Is anyone working on this fix?

---------------------------------------------------------------------------

Tom Lane wrote:
> Log Message:
> -----------
> Remove some of the most blatant brain-fade in the recent guc patch
> (it's so nice to have a buildfarm member that actively rejects naked
> uses of strcasecmp).  This coding is still pretty awful, though, since
> it's going to be O(N^2) in the number of guc variables.  May I direct
> your attention to bsearch?
> 
> Modified Files:
> --------------
>     pgsql/src/backend/utils/misc:
>         guc.c (r1.387 -> r1.388)
>         (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c.diff?r1=1.387&r2=1.388)
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

--  Bruce Momjian  <bruce@momjian.us>          http://momjian.us EnterpriseDB
http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


Re: [COMMITTERS] pgsql: Remove some of the most blatant brain-fade in the recent guc

От
Tom Lane
Дата:
Bruce Momjian <bruce@momjian.us> writes:
> Is anyone working on this fix?

I dunno, but that patch is gonna get reverted altogether if someone
doesn't fix the fact that it broke PGCLIENTENCODING ...
        regards, tom lane