Обсуждение: Re: [COMMITTERS] pgsql: RESET SESSION, plus related new DDL commands.

Поиск
Список
Период
Сортировка

Re: [COMMITTERS] pgsql: RESET SESSION, plus related new DDL commands.

От
Alvaro Herrera
Дата:
Neil Conway wrote:
> Log Message:
> -----------
> RESET SESSION, plus related new DDL commands.

This phrase is missing a verb:
The default value is defined as the value that the parameter wouldhave had, if no <command>SET</> ever been issued for
itin thecurrent session. 
 

/pgsql/doc/src/sgml/ref/reset.sgml


I find this markup strange:

<synopsis>      SET SESSION AUTHORIZATION DEFAULT;      RESET ALL;      DEALLOCATE ALL;      CLOSE ALL;      UNLISTEN
*;     RESET PLANS;      RESET TEMP;
 
</synopsis>

shouldn't it be using <programlisting> ?


In ResetTempTableNamespace(void), shouldn't it be using myTempNamespace
instead of the SysCache lookup?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


Re: [COMMITTERS] pgsql: RESET SESSION, plus related new DDL commands.

От
Neil Conway
Дата:
On Thu, 2007-04-12 at 11:45 -0400, Alvaro Herrera wrote:
> This phrase is missing a verb:
> [...]
> I find this markup strange:
> [...]
> In ResetTempTableNamespace(void), shouldn't it be using myTempNamespace
> instead of the SysCache lookup?

All fair points: I've applied the attached patch. Thanks for the review.

-Neil


Вложения