Обсуждение: Re: [COMMITTERS] pgsql: Clean up code associated with updating pg_class statistics

Tom Lane wrote:
> Log Message:
> -----------
> Clean up code associated with updating pg_class statistics columns
> (relpages/reltuples).  To do this, create formal support in heapam.c for
> "overwrite" tuple updates (including xlog replay capability) and use that
> instead of the ad-hoc overwrites we'd been using in VACUUM and CREATE INDEX.
> Take the responsibility for updating stats during CREATE INDEX out of the
> individual index AMs, and do it where it belongs, in catalog/index.c.  Aside
> from being more modular, this avoids having to update the same tuple twice in
> some paths through CREATE INDEX.  It's probably not measurably faster, but
> for sure it's a lot cleaner than before.

Minor comment: since you removed the ----- lines from the index_create
header comment, I think pgindent will mess up the alignment for that
comment, which probably will not be very nice.  Same in
index_update_stats.  Otherwise, nice work!  I will update my relminxid
patch to this and re-submit.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Minor comment: since you removed the ----- lines from the index_create
> header comment, I think pgindent will mess up the alignment for that
> comment, which probably will not be very nice.  Same in
> index_update_stats.  Otherwise, nice work!  I will update my relminxid
> patch to this and re-submit.

No, left-justified comments aren't subject to reindenting (correct Bruce?)
Certainly there are plenty of other function header comments that don't
have any ---.
        regards, tom lane

Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > Minor comment: since you removed the ----- lines from the index_create
> > header comment, I think pgindent will mess up the alignment for that
> > comment, which probably will not be very nice.  Same in
> > index_update_stats.  Otherwise, nice work!  I will update my relminxid
> > patch to this and re-submit.
> 
> No, left-justified comments aren't subject to reindenting (correct Bruce?)

Correct.

--  Bruce Momjian   http://candle.pha.pa.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +