Обсуждение: Resurrecting some old patches
Hi, Late last year I posted some patches for psql but they were deferred pending the release of 8.2. However, they are not in the patch queue so I thought I'd bring them up again now the release is done. 1. Dealing with a buggy readline on some platforms w.r.t. --as-needed. The serious arguments for --as-needed have gone now we exclude various libs from the main postgres binary. However, the other executables still include a lot more libs than necessary. http://archives.postgresql.org/pgsql-hackers/2005-10/msg01364.php 2. Handling Ctrl-C pressed while running an external pager. This bug still irritates me from time to time so it would be nice to fix it for once and for all. Not to meantion the memory and file descriptor leaks caused by the current code. However, the tree has deviated significantly since that patch was posted. I have prepared a version against HEAD if people are still interested. The details are in this message: http://archives.postgresql.org/pgsql-patches/2005-10/msg00194.php The only change from that is that I've now also removed paging support from the following programs: createdb, createlang, createuser, dropdb, droplang, dropuser, clusterdb, vacuumdb, reindexdb. In so far as it's not clear how much they used the paging support anyway, keeping it would require setting up of the signal handlers the same way psql does since the code is shared. I figured it wasn't worth it. The new patch is here but can be posted to -patches if there is sufficient interest: http://svana.org/kleptog/pgsql/psql-ctrlc2.patch Have a nice day, -- Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting around waiting for someone > else to do the other 95% so you can sue them.
Aren't they in the 8.2 hold queue that I have not processed yet: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --------------------------------------------------------------------------- Martijn van Oosterhout wrote: -- Start of PGP signed section. > Hi, > > Late last year I posted some patches for psql but they were deferred > pending the release of 8.2. However, they are not in the patch queue > so I thought I'd bring them up again now the release is done. > > 1. Dealing with a buggy readline on some platforms w.r.t. --as-needed. > > The serious arguments for --as-needed have gone now we exclude various > libs from the main postgres binary. However, the other executables > still include a lot more libs than necessary. > > http://archives.postgresql.org/pgsql-hackers/2005-10/msg01364.php > > 2. Handling Ctrl-C pressed while running an external pager. > > This bug still irritates me from time to time so it would be nice to > fix it for once and for all. Not to meantion the memory and file > descriptor leaks caused by the current code. However, the tree has > deviated significantly since that patch was posted. I have prepared a > version against HEAD if people are still interested. The details are in > this message: > > http://archives.postgresql.org/pgsql-patches/2005-10/msg00194.php > > The only change from that is that I've now also removed paging support > from the following programs: > > createdb, createlang, createuser, dropdb, droplang, dropuser, > clusterdb, vacuumdb, reindexdb. > > In so far as it's not clear how much they used the paging support > anyway, keeping it would require setting up of the signal handlers the > same way psql does since the code is shared. I figured it wasn't worth > it. > > The new patch is here but can be posted to -patches if there is > sufficient interest: > http://svana.org/kleptog/pgsql/psql-ctrlc2.patch > > Have a nice day, > -- > Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/ > > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > > tool for doing 5% of the work and then sitting around waiting for someone > > else to do the other 95% so you can sue them. -- End of PGP section, PGP failed! -- Bruce Momjian http://candle.pha.pa.us SRA OSS, Inc. http://www.sraoss.com + If your life is a hard drive, Christ can be your backup. +
On Fri, Feb 24, 2006 at 10:15:39PM -0500, Bruce Momjian wrote: > > Aren't they in the 8.2 hold queue that I have not processed yet: > > http://momjian.postgresql.org/cgi-bin/pgpatches_hold Hmm yeah. Didn't know about that page. The first is ok but the second no longer applies cleanly to HEAD so I posted an update. There's no particular point reviewing the old patch since psql changed quite a bit between now and then. If you somehow mark the held queue so people look at that email and the new patch rather than the old one, that'd be great. Have a nice day, -- Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting around waiting for someone > else to do the other 95% so you can sue them.
OK. --------------------------------------------------------------------------- Martijn van Oosterhout wrote: -- Start of PGP signed section. > On Fri, Feb 24, 2006 at 10:15:39PM -0500, Bruce Momjian wrote: > > > > Aren't they in the 8.2 hold queue that I have not processed yet: > > > > http://momjian.postgresql.org/cgi-bin/pgpatches_hold > > Hmm yeah. Didn't know about that page. > > The first is ok but the second no longer applies cleanly to HEAD so I > posted an update. There's no particular point reviewing the old patch > since psql changed quite a bit between now and then. > > If you somehow mark the held queue so people look at that email and the > new patch rather than the old one, that'd be great. > > Have a nice day, > -- > Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/ > > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > > tool for doing 5% of the work and then sitting around waiting for someone > > else to do the other 95% so you can sue them. -- End of PGP section, PGP failed! -- Bruce Momjian http://candle.pha.pa.us SRA OSS, Inc. http://www.sraoss.com + If your life is a hard drive, Christ can be your backup. +