Обсуждение: Re: [COMMITTERS] pgsql-server: plperl update from Andrew Dunstan,

Поиск
Список
Период
Сортировка

Re: [COMMITTERS] pgsql-server: plperl update from Andrew Dunstan,

От
Andrew Dunstan
Дата:
[redirected to -hackers]

Tom Lane wrote:

>joe@svr1.postgresql.org (Joe Conway) writes:
>  
>
>>plperl update from Andrew Dunstan, deriving (I believe) from Command Prompt's
>>plperlNG. Review and minor cleanup/improvements by Joe Conway.
>>    
>>
>
>I've reverted the part of this patch that attempted to make plperl use
>rpath, because it doesn't actually work...
>
>
>  
>
[snip]

>-Wl is a gcc-ism, I believe; it certainly won't work in a direct call to
>ld.  Looking at the port makefiles, HPUX is not the only platform that
>will barf on this.
>
>
>  
>

Is there a more portable way of doing this, via configure maybe?

cheers

andrew


Re: [COMMITTERS] pgsql-server: plperl update from Andrew Dunstan, deriving (I believe)

От
Tom Lane
Дата:
Andrew Dunstan <andrew@dunslane.net> writes:
>> I've reverted the part of this patch that attempted to make plperl use
>> rpath, because it doesn't actually work...

> Is there a more portable way of doing this, via configure maybe?

It doesn't look to me like we handle rpath switch syntax via configure,
but by setting variables in the port-specific makefiles.  Maybe you
could extend that scheme so that the switch name is available separately
from $(libdir).

The HPUX case is slightly peculiar because we essentially force rpath to
be used always; enable_rpath is disregarded and we stick what would be
the rpath switches directly into LDFLAGS.  It might be cleaner if it
did this by setting enable_rpath true in the port makefile, instead of
bypassing the rpath variable mechanism altogether.
        regards, tom lane